From: Dagfinn Ilmari Mannsåker Date: Mon, 12 Aug 2013 20:03:16 +0000 (+0100) Subject: Fix typos in POD and comments (RT#87776) X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=3af02ccb064ba561a4e7b0f6638df2ecc3df8b81;p=scpubgit%2FQ-Branch.git Fix typos in POD and comments (RT#87776) --- diff --git a/Changes b/Changes index 94b71b1..e6488a4 100644 --- a/Changes +++ b/Changes @@ -1,6 +1,7 @@ Revision history for SQL::Abstract - Fix false negative comparison of ORDER BY ASC + - Fix typos in POD and comments (RT#87776) revision 1.74 2013-06-04 ---------------------------- diff --git a/lib/SQL/Abstract.pm b/lib/SQL/Abstract.pm index 3940881..4609e5d 100644 --- a/lib/SQL/Abstract.pm +++ b/lib/SQL/Abstract.pm @@ -86,7 +86,7 @@ sub new { # default comparison is "=", but can be overridden $opt{cmp} ||= '='; - # try to recognize which are the 'equality' and 'unequality' ops + # try to recognize which are the 'equality' and 'inequality' ops # (temporary quickfix, should go through a more seasoned API) $opt{equality_op} = qr/^(\Q$opt{cmp}\E|is|(is\s+)?like)$/i; $opt{inequality_op} = qr/^(!=|<>|(is\s+)?not(\s+like)?)$/i; @@ -104,7 +104,7 @@ sub new { $opt{unary_ops} ||= []; push @{$opt{unary_ops}}, @BUILTIN_UNARY_OPS; - # rudimentary saniy-check for user supplied bits treated as functions/operators + # rudimentary sanity-check for user supplied bits treated as functions/operators # If a purported function matches this regular expression, an exception is thrown. # Literal SQL is *NOT* subject to this check, only functions (and column names # when quoting is not in effect) @@ -1699,7 +1699,7 @@ C to C you would get SQL such as: WHERE name like 'nwiger' AND email like 'nate@wiger.org' -You can also override the comparsion on an individual basis - see +You can also override the comparison on an individual basis - see the huge section on L at the bottom. =item sqltrue, sqlfalse @@ -2431,7 +2431,7 @@ Note that if you were to simply say: array => [1, 2, 3] ); -the result would porbably be not what you wanted: +the result would probably not be what you wanted: $stmt = 'WHERE array = ? OR array = ? OR array = ?'; @bind = (1, 2, 3); diff --git a/lib/SQL/Abstract/Tree.pm b/lib/SQL/Abstract/Tree.pm index 60a1aa2..5b1cbfe 100644 --- a/lib/SQL/Abstract/Tree.pm +++ b/lib/SQL/Abstract/Tree.pm @@ -91,8 +91,8 @@ $expr_start_re = qr/ $op_look_behind (?i: $expr_start_re ) $op_look_ahead /x; # These are binary operator keywords always a single LHS and RHS # * AND/OR are handled separately as they are N-ary # * so is NOT as being unary -# * BETWEEN without paranthesis around the ANDed arguments (which -# makes it a non-binary op) is detected and accomodated in +# * BETWEEN without parentheses around the ANDed arguments (which +# makes it a non-binary op) is detected and accommodated in # _recurse_parse() # * AS is not really an operator but is handled here as it's also LHS/RHS @@ -136,7 +136,7 @@ my $tokenizer_re = join("\n\t|\n", # this one *is* capturing for the split below # splits on whitespace if all else fails -# has to happen before the composiign qr's are anchored (below) +# has to happen before the composing qr's are anchored (below) $tokenizer_re = qr/ \s* ( $tokenizer_re ) \s* | \s+ /x; # Parser states for _recurse_parse() @@ -649,7 +649,7 @@ sub _parenthesis_unroll { $changes++; } - # if the parent operator explcitly allows it nuke the parenthesis + # if the parent operator explicitly allows it nuke the parenthesis if ( $ast->[0] =~ $unrollable_ops_re ) { push @children, @{$child->[1]}; $changes++;