From: Arthur Axel 'fREW' Schmidt <frioux@gmail.com>
Date: Thu, 22 Jul 2010 04:21:41 +0000 (-0500)
Subject: remove Dumper() silliness
X-Git-Tag: v2.000~2
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=39d55febf4cd4843f5bb61b5603ae1aecd7bb186;p=p5sagit%2FData-Dumper-Concise.git

remove Dumper() silliness
---

diff --git a/Changes b/Changes
index 228858c..2fd9b2c 100644
--- a/Changes
+++ b/Changes
@@ -1,3 +1,4 @@
+  - remove Dumper() returning object
   - add DwarnL
   - make Dwarn contextual
   - document ::Dwarn idiom
diff --git a/lib/Data/Dumper/Concise.pm b/lib/Data/Dumper/Concise.pm
index 2220af7..b829179 100644
--- a/lib/Data/Dumper/Concise.pm
+++ b/lib/Data/Dumper/Concise.pm
@@ -14,7 +14,6 @@ BEGIN { @ISA = qw(Exporter) }
 sub Dumper {
   my $dd = Data::Dumper->new([]);
   $dd->Terse(1)->Indent(1)->Useqq(1)->Deparse(1)->Quotekeys(0)->Sortkeys(1);
-  return $dd unless @_;
   return $dd->Values([ @_ ])->Dump;
 }
 
@@ -41,20 +40,6 @@ is equivalent to:
     warn Dumper($var);
   }
 
-whereas
-
-  my $dd = Dumper;
-
-is equivalent to:
-
-  my $dd = Data::Dumper->new([])
-                       ->Terse(1)
-                       ->Indent(1)
-                       ->Useqq(1)
-                       ->Deparse(1)
-                       ->Quotekeys(0)
-                       ->Sortkeys(1);
-
 So for the structure:
 
   { foo => "bar\nbaz", quux => sub { "fleem" } };
@@ -83,16 +68,7 @@ instead of the default Data::Dumper output:
 =head1 DESCRIPTION
 
 This module always exports a single function, Dumper, which can be called
-with an array of values to dump those values or with no arguments to
-return the Data::Dumper object it's created. Note that this means that
-
-  Dumper @list
-
-will probably not do what you wanted when @list is empty. In this case use
-
-  Dumper \@list
-
-instead.
+with an array of values to dump those values.
 
 It exists, fundamentally, as a convenient way to reproduce a set of Dumper
 options that we've found ourselves using across large numbers of applications,
@@ -146,7 +122,7 @@ frew - Arthur Axel "fREW" Schmidt <frioux@gmail.com>
 
 =head1 COPYRIGHT
 
-Copyright (c) 2009 the Data::Dumper::Concise L</AUTHOR> and L</CONTRIBUTORS>
+Copyright (c) 2010 the Data::Dumper::Concise L</AUTHOR> and L</CONTRIBUTORS>
 as listed above.
 
 =head1 LICENSE
diff --git a/t/concise.t b/t/concise.t
index 6b45dd5..df5e48f 100644
--- a/t/concise.t
+++ b/t/concise.t
@@ -12,16 +12,13 @@ my $dd = Data::Dumper->new([])
                      ->Quotekeys(0)
                      ->Sortkeys(1);
 
-my $dd_c = Dumper;
-
 foreach my $to_dump (
   [ { foo => "bar\nbaz", quux => sub { "fleem" }  } ],
   [ 'one', 'two' ]
 ) {
 
-  $dd_c->Values([ @$to_dump ]);
   $dd->Values([ @$to_dump ]);
-  
+
   my $example = do {
     local $Data::Dumper::Terse = 1;
     local $Data::Dumper::Indent = 1;
@@ -31,10 +28,8 @@ foreach my $to_dump (
     local $Data::Dumper::Sortkeys = 1;
     Data::Dumper::Dumper(@$to_dump);
   };
-  
+
   is($example, $dd->Dump, 'Both Data::Dumper usages equivalent');
-  
-  is($example, $dd_c->Dump, 'Returned object usage equivalent');
-  
+
   is($example, Dumper(@$to_dump), 'Subroutine call usage equivalent');
 }