From: Andreas J. Koenig <koenig@anna.mind.de>
Date: Fri, 5 Sep 1997 00:00:00 +0000 (+0000)
Subject: Identify t/*/*.t test failing because of file permissions
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=387deb6900d02a5b43888a2b575e6eb9b91f9aac;p=p5sagit%2Fp5-mst-13.2.git

Identify t/*/*.t test failing because of file permissions

tim> I've added
tim> 	system("find t -name '*.t' -print | xargs chmod +x");
tim> to my Porting/makerel script. So the problem should not reappear.

That doesn't help for the patch. The perl5.004m4t1.patch.gz contained

    touch t/lib/dosglob.t

but no

    chmod +x t/lib/dosglob.t

Short term I'd recommend Ilya's one-line patch to t/TEST because it at
least saves us debugging time. Stupid me lost over an hour not
understanding the reason for the failure. Here it is:

p5p-msgid: sfcraah0xvy.fsf@anna.in-berlin.de
---

diff --git a/t/TEST b/t/TEST
index ae43666..cae8103 100755
--- a/t/TEST
+++ b/t/TEST
@@ -51,6 +51,7 @@ while ($test = shift) {
     chop($te);
     print "$te" . '.' x (18 - length($te));
     if ($sharpbang) {
+	-x $test || (print "isn't executable.\n");
 	open(RESULTS,"./$test |") || (print "can't run.\n");
     } else {
 	open(SCRIPT,"$test") || die "Can't run $test.\n";