From: Peter Rabbitson <ribasushi@cpan.org>
Date: Sat, 6 Mar 2010 11:27:28 +0000 (+0000)
Subject: Fully deprecate IC::File
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=3814fdaddf1c49d2a8055c6da60cd93a1b513ad7;p=dbsrgits%2FDBIx-Class-Historic.git

Fully deprecate IC::File
---

diff --git a/lib/DBIx/Class/InflateColumn/File.pm b/lib/DBIx/Class/InflateColumn/File.pm
index c1f75ea..951b76e 100644
--- a/lib/DBIx/Class/InflateColumn/File.pm
+++ b/lib/DBIx/Class/InflateColumn/File.pm
@@ -7,6 +7,17 @@ use File::Path;
 use File::Copy;
 use Path::Class;
 
+use Carp::Clan qw/^DBIx::Class/;
+carp 'InflateColumn::File has entered a deprecation cycle. This component '
+    .'has a number of architectural deficiencies that can quickly drive '
+    .'your filesystem and database out of sync and is not recommended '
+    .'for further use. It will be retained for backwards '
+    .'compatibility, but no new functionality patches will be accepted. '
+    .'Please consider using the much more mature and actively maintained '
+    .'DBIx::Class::InflateColumn::FS. You can set the environment variable '
+    .'DBIC_IC_FILE_NOWARN to a true value to disable  this warning.'
+unless $ENV{DBIC_IC_FILE_NOWARN};
+
 __PACKAGE__->load_components(qw/InflateColumn/);
 
 sub register_column {
@@ -111,11 +122,13 @@ DBIx::Class::InflateColumn::File -  DEPRECATED (superseded by DBIx::Class::Infla
 
 =head2 Deprecation Notice
 
- This component has a number of architectural deficiencies and is not
- recommended for further use. It will be retained for backwards
- compatibility, but no new functionality patches will be accepted.
- Please consider using the much more mature and actively supported
- DBIx::Class::InflateColumn::FS
+ This component has a number of architectural deficiencies that can quickly
+ drive your filesystem and database out of sync and is not recommended for
+ further use. It will be retained for backwards compatibility, but no new
+ functionality patches will be accepted. Please consider using the much more
+ mature and actively supported DBIx::Class::InflateColumn::FS. You can set
+ the environment variable DBIC_IC_FILE_NOWARN to a true value to disable
+ this warning.
 
 =head1 SYNOPSIS
 
diff --git a/t/inflate/file_column.t b/t/inflate/file_column.t
index 639b12d..4de177a 100644
--- a/t/inflate/file_column.t
+++ b/t/inflate/file_column.t
@@ -1,13 +1,18 @@
 use strict;
-use warnings;  
+use warnings;
 
 use Test::More;
 use lib qw(t/lib);
 use DBICTest;
+use DBICTest::Schema;
 use File::Compare;
 use Path::Class qw/file/;
 
-my $schema = DBICTest->init_schema();
+$ENV{DBIC_IC_FILE_NOWARN} = 1;
+
+DBICTest::Schema->load_classes ('FileColumn');
+my $schema = DBICTest::Schema->connect(DBICTest->_database);
+DBICTest->deploy_schema ($schema);
 
 plan tests => 10;
 
diff --git a/t/lib/DBICTest/Schema.pm b/t/lib/DBICTest/Schema.pm
index a3e4484..ac8c5ba 100644
--- a/t/lib/DBICTest/Schema.pm
+++ b/t/lib/DBICTest/Schema.pm
@@ -11,7 +11,6 @@ __PACKAGE__->load_classes(qw/
   BindType
   Employee
   CD
-  FileColumn
   Genre
   Link
   Bookmark
diff --git a/t/lib/sqlite.sql b/t/lib/sqlite.sql
index 4d7905f..d90842d 100644
--- a/t/lib/sqlite.sql
+++ b/t/lib/sqlite.sql
@@ -1,6 +1,6 @@
 -- 
 -- Created by SQL::Translator::Producer::SQLite
--- Created on Sat Jan 30 19:18:55 2010
+-- Created on Sat Mar  6 12:26:40 2010
 -- 
 ;
 
@@ -68,14 +68,6 @@ CREATE TABLE event (
 );
 
 --
--- Table: file_columns
---
-CREATE TABLE file_columns (
-  id INTEGER PRIMARY KEY NOT NULL,
-  file varchar(255) NOT NULL
-);
-
---
 -- Table: fourkeys
 --
 CREATE TABLE fourkeys (