From: Dagfinn Ilmari Mannsåker Date: Sat, 15 Mar 2008 05:26:05 +0000 (+0000) Subject: Eliminate remaining uses of $self->dbh_do($self->can(...), ...) now that dbh_do can... X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=373940e16de14913107bcd5cbb6e6a286a6b795e;p=dbsrgits%2FDBIx-Class-Historic.git Eliminate remaining uses of $self->dbh_do($self->can(...), ...) now that dbh_do can take a method name --- diff --git a/lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm b/lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm index a786659..07abe57 100644 --- a/lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm +++ b/lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm @@ -78,7 +78,7 @@ Returns the sequence name for an autoincrement column sub get_autoinc_seq { my ($self, $source, $col) = @_; - $self->dbh_do($self->can('_dbh_get_autoinc_seq'), $source, $col); + $self->dbh_do('_dbh_get_autoinc_seq', $source, $col); } =head2 columns_info_for diff --git a/lib/DBIx/Class/Storage/DBI/Pg.pm b/lib/DBIx/Class/Storage/DBI/Pg.pm index 2373991..a2d7f1e 100644 --- a/lib/DBIx/Class/Storage/DBI/Pg.pm +++ b/lib/DBIx/Class/Storage/DBI/Pg.pm @@ -24,7 +24,7 @@ sub last_insert_id { $self->throw_exception("could not fetch primary key for " . $source->name . ", could not " . "get autoinc sequence for $col (check that table and column specifications are correct " . "and in the correct case)") unless defined $seq; - $self->dbh_do($self->can('_dbh_last_insert_id'), $seq); + $self->dbh_do('_dbh_last_insert_id', $seq); } sub _dbh_get_autoinc_seq { @@ -49,7 +49,7 @@ sub get_autoinc_seq { my ($schema,$table) = $source->name =~ /^(.+)\.(.+)$/ ? ($1,$2) : (undef,$source->name); - $self->dbh_do($self->can('_dbh_get_autoinc_seq'), $schema, $table, @pri); + $self->dbh_do('_dbh_get_autoinc_seq', $schema, $table, @pri); } sub sqlt_type {