From: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
Date: Fri, 8 May 2009 20:40:09 +0000 (+0200)
Subject: Inline macros used only once
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=365c4e3d7660763689bc62ead0a9a495a26bcad7;p=p5sagit%2Fp5-mst-13.2.git

Inline macros used only once
---

diff --git a/pp_ctl.c b/pp_ctl.c
index c601f7c..6a5ea65 100644
--- a/pp_ctl.c
+++ b/pp_ctl.c
@@ -4000,12 +4000,6 @@ S_do_smartmatch(pTHX_ HV *seen_this, HV *seen_other)
     SV *e = TOPs;	/* e is for 'expression' */
     SV *d = TOPm1s;	/* d is for 'default', as in PL_defgv */
 
-#   define SM_SEEN_THIS(sv) hv_exists_ent(seen_this, \
-	sv_2mortal(newSViv(PTR2IV(sv))), 0)
-
-#   define SM_SEEN_OTHER(sv) hv_exists_ent(seen_other, \
-	sv_2mortal(newSViv(PTR2IV(sv))), 0)
-
     if (SvAMAGIC(e)) {
 	SV * const tmpsv = amagic_call(d, e, smart_amg, 0);
 	if (tmpsv) {
@@ -4265,8 +4259,10 @@ S_do_smartmatch(pTHX_ HV *seen_this, HV *seen_other)
 			if (this_elem || other_elem)
 			    RETPUSHNO;
 		    }
-		    else if (SM_SEEN_THIS(*this_elem)
-			 || SM_SEEN_OTHER(*other_elem))
+		    else if (hv_exists_ent(seen_this,
+				sv_2mortal(newSViv(PTR2IV(*this_elem))), 0) ||
+			    hv_exists_ent(seen_other,
+				sv_2mortal(newSViv(PTR2IV(*other_elem))), 0))
 		    {
 			if (*this_elem != *other_elem)
 			    RETPUSHNO;