From: Rafael Kitover <rkitover@cpan.org>
Date: Thu, 24 Nov 2011 18:31:22 +0000 (-0500)
Subject: Silence freetds/ODBC test warnings
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=35af31a1de45ad6fa7cbe581b2efe0aa4738de98;p=dbsrgits%2FDBIx-Class-Historic.git

Silence freetds/ODBC test warnings

The freetds+dynamic cursors TODO tests are throwing a warning for undef
in ->find, set the DBIC_NULLABLE_KEY_NOWARN env var to silence them.
This is not a solution of course, but we will deal with it when we
resolve the underlying issues with freetds and dynamic cursors.
---

diff --git a/t/746mssql.t b/t/746mssql.t
index 36a405f..620258e 100644
--- a/t/746mssql.t
+++ b/t/746mssql.t
@@ -534,10 +534,15 @@ SQL
       });
 
       TODO: {
-        local $TODO =
+        my $freetds_and_dynamic_cursors = 1
+          if $opts_name eq 'use_dynamic_cursors' &&
+            $schema->storage->using_freetds;
+
+        local $TODO = 
 'these tests fail on freetds with dynamic cursors for some reason'
-          if $opts_name eq 'use_dynamic_cursors'
-             && $schema->storage->using_freetds;
+          if $freetds_and_dynamic_cursors;
+        local $ENV{DBIC_NULLABLE_KEY_NOWARN} = 1
+          if $freetds_and_dynamic_cursors;
 
         my $rs = $schema->resultset('Money');
         my $row;