From: Justin Hunter <justin.d.hunter@gmail.com>
Date: Fri, 13 Mar 2009 07:11:57 +0000 (+0000)
Subject: rewrite _bind_to_sql to not replace ? with the bindvars, have select return with... 
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=3515960de2860244761b586a21296912f384ded5;p=dbsrgits%2FDBIx-Class-Historic.git

rewrite _bind_to_sql to not replace ? with the bindvars, have select return with from_bind
---

diff --git a/lib/DBIx/Class/Storage/DBI.pm b/lib/DBIx/Class/Storage/DBI.pm
index 54491a7..c27647c 100644
--- a/lib/DBIx/Class/Storage/DBI.pm
+++ b/lib/DBIx/Class/Storage/DBI.pm
@@ -96,20 +96,11 @@ sub _find_syntax {
 sub select {
   my ($self, $table, $fields, $where, $order, @rest) = @_;
   local $self->{having_bind} = [];
+  local $self->{from_bind} = [];
 
-#  if (ref $table eq 'HASH') {
-#    my $alias;
-#    ($alias, $table) = %$table;
-#  }
- 
   if (ref $table eq 'SCALAR') {
     $table = $$table;
   }
-  elsif (ref $table eq 'REF') {
-    my ($sql, @bind) = @{${$table}};
-    push(@{$self->{having_bind}}, @bind);
-    $table = $sql;
-  }
   elsif (not ref $table) {
     $table = $self->_quote($table);
   }
@@ -118,7 +109,7 @@ sub select {
   @rest = (-1) unless defined $rest[0];
   die "LIMIT 0 Does Not Compute" if $rest[0] == 0;
     # and anyway, SQL::Abstract::Limit will cause a barf if we don't first
-  my ($sql, @ret) = $self->SUPER::select(
+  my ($sql, @where_bind) = $self->SUPER::select(
     $table, $self->_recurse_fields($fields), $where, $order, @rest
   );
   $sql .= 
@@ -130,7 +121,7 @@ sub select {
     ) :
     ''
   ;
-  return wantarray ? ($sql, @ret, @{$self->{having_bind}}) : $sql;
+  return wantarray ? ($sql, @{$self->{from_bind}}, @where_bind, @{$self->{having_bind}}) : $sql;
 }
 
 sub insert {
@@ -278,11 +269,10 @@ sub _recurse_from {
 }
 
 sub _bind_to_sql {
-  my $self = shift;
-  my $arr  = shift;
-  my $sql = shift @$$arr;
-  $sql =~ s/\?/$self->_quote((shift @$$arr)->[1])/eg;
-  return $sql
+  my ($self, $arr) = @_;
+  my ($sql, @bind) = @{${$arr}};
+  push (@{$self->{from_bind}}, @bind);
+  return $sql;
 }
 
 sub _make_as {