From: Matt S Trout Date: Wed, 8 Mar 2006 16:04:27 +0000 (+0000) Subject: Nuked a couple of pointless warns and a Dumper load X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=34063e8d23563429066d67a10d3c4d8cce06bcc5;p=dbsrgits%2FDBIx-Class-Historic.git Nuked a couple of pointless warns and a Dumper load --- diff --git a/lib/DBIx/Class/ResultSet.pm b/lib/DBIx/Class/ResultSet.pm index d994549..b13d3a5 100644 --- a/lib/DBIx/Class/ResultSet.pm +++ b/lib/DBIx/Class/ResultSet.pm @@ -424,7 +424,6 @@ sub _construct_object { my $info = $self->_collapse_result(\@as, \@row); - #use Data::Dumper; warn Dumper(\@as, $info); my $new = $self->result_class->inflate_result($self->result_source, @$info); $new = $self->{attrs}{record_filter}->($new) @@ -453,7 +452,6 @@ sub _collapse_result { } } - #warn "@cols -> @row"; my $info = [ {}, {} ]; foreach my $key (keys %const) { if (length $key) { @@ -474,9 +472,7 @@ sub _collapse_result { : keys %{$self->{collapse}}); if (@collapse) { my ($c) = sort { length $a <=> length $b } @collapse; - #warn "Collapsing ${c}"; my $target = $info; - #warn Data::Dumper::Dumper($target); foreach my $p (split(/\./, $c)) { $target = $target->[1]->{$p} ||= []; } @@ -484,7 +480,6 @@ sub _collapse_result { my @co_key = @{$self->{collapse}{$c_prefix}}; my %co_check = map { ($_, $target->[0]->{$_}); } @co_key; my $tree = $self->_collapse_result($as, $row, $c_prefix); - #warn Data::Dumper::Dumper($tree, $row); my (@final, @raw); while ( !(grep { !defined($tree->[0]->{$_}) @@ -497,12 +492,8 @@ sub _collapse_result { #warn Data::Dumper::Dumper($tree, $row); } @{$target} = @final; - #warn Data::Dumper::Dumper($target); - #warn Data::Dumper::Dumper($info); } - #warn Dumper($info); - return $info; } diff --git a/lib/DBIx/Class/ResultSource.pm b/lib/DBIx/Class/ResultSource.pm index 22cbdf1..e8b1b96 100644 --- a/lib/DBIx/Class/ResultSource.pm +++ b/lib/DBIx/Class/ResultSource.pm @@ -547,7 +547,6 @@ in the supplied relationships. Examples: sub resolve_prefetch { my ($self, $pre, $alias, $seen, $order, $collapse) = @_; $seen ||= {}; - use Data::Dumper; #$alias ||= $self->name; #warn $alias, Dumper $pre; if( ref $pre eq 'ARRAY' ) {