From: Dan Sully <daniel@cpan.org>
Date: Wed, 4 Oct 2006 18:19:37 +0000 (+0000)
Subject: Make UTF-8 columns work under Perl <= 5.8.0
X-Git-Tag: v0.07003~35
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=337c98ef113c56111e11a3af9043acdb7133106b;p=dbsrgits%2FDBIx-Class.git

Make UTF-8 columns work under Perl <= 5.8.0
---

diff --git a/lib/DBIx/Class/UTF8Columns.pm b/lib/DBIx/Class/UTF8Columns.pm
index bcd45cb..f060f81 100644
--- a/lib/DBIx/Class/UTF8Columns.pm
+++ b/lib/DBIx/Class/UTF8Columns.pm
@@ -3,7 +3,16 @@ use strict;
 use warnings;
 use base qw/DBIx::Class/;
 
-use utf8;
+BEGIN {
+
+    # Perl 5.8.0 doesn't have utf8::is_utf8()
+    # Yes, 5.8.0 support for Unicode is suboptimal, but things like RHEL3 ship with it.
+    if ($] <= 5.008000) {
+        require Encode;
+    } else {
+        require utf8;
+    }
+}
 
 __PACKAGE__->mk_classdata( '_utf8_columns' );
 
@@ -60,8 +69,13 @@ sub get_column {
 
     my $cols = $self->_utf8_columns;
     if ( $cols and defined $value and $cols->{$column} ) {
-        utf8::decode($value) unless utf8::is_utf8($value);
-   }
+
+        if ($] <= 5.008000) {
+            Encode::_utf8_on($value) unless Encode::is_utf8($value);
+        } else {
+            utf8::decode($value) unless utf8::is_utf8($value);
+        }
+    }
 
     $value;
 }
@@ -75,7 +89,12 @@ sub get_columns {
     my %data = $self->next::method(@_);
 
     foreach my $col (grep { defined $data{$_} } keys %{ $self->_utf8_columns || {} }) {
-        utf8::decode($data{$col}) unless utf8::is_utf8($data{$col});
+
+        if ($] <= 5.008000) {
+            Encode::_utf8_on($data{$col}) unless Encode::is_utf8($data{$col});
+        } else {
+            utf8::decode($data{$col}) unless utf8::is_utf8($data{$col});
+        }
     }
 
     %data;
@@ -90,7 +109,12 @@ sub store_column {
 
     my $cols = $self->_utf8_columns;
     if ( $cols and defined $value and $cols->{$column} ) {
-        utf8::encode($value) if utf8::is_utf8($value);
+
+        if ($] <= 5.008000) {
+            Encode::_utf8_off($value) if Encode::is_utf8($value);
+        } else {
+            utf8::encode($value) if utf8::is_utf8($value);
+        }
     }
 
     $self->next::method( $column, $value );
diff --git a/t/85utf8.t b/t/85utf8.t
index a18814d..8ef3bda 100644
--- a/t/85utf8.t
+++ b/t/85utf8.t
@@ -7,8 +7,14 @@ use DBICTest;
 
 my $schema = DBICTest->init_schema();
 
-eval 'use utf8; 1'
-    or plan skip_all => 'Need utf8 run this test';
+if ($] <= 5.008000) {
+
+    eval 'use Encode; 1' or plan skip_all => 'Need Encode run this test';
+
+} else {
+
+    eval 'use utf8; 1' or plan skip_all => 'Need utf8 run this test';
+}
 
 plan tests => 3;
 
@@ -17,12 +23,23 @@ DBICTest::Schema::CD->utf8_columns('title');
 Class::C3->reinitialize();
 
 my $cd = $schema->resultset('CD')->create( { artist => 1, title => 'øni', year => 'foo' } );
-ok( utf8::is_utf8( $cd->title ), 'got title with utf8 flag' );
-ok( !utf8::is_utf8( $cd->year ), 'got year without utf8 flag' );
-
 my $utf8_char = 'uniuni';
-utf8::decode($utf8_char);
-$cd->title($utf8_char);
-ok( !utf8::is_utf8( $cd->{_column_data}{title} ),
-    'store utf8-less chars' );
 
+if ($] <= 5.008000) {
+
+    ok( Encode::is_utf8( $cd->title ), 'got title with utf8 flag' );
+    ok( !Encode::is_utf8( $cd->year ), 'got year without utf8 flag' );
+
+    Encode::_utf8_on($utf8_char);
+    $cd->title($utf8_char);
+    ok( !Encode::is_utf8( $cd->{_column_data}{title} ), 'store utf8-less chars' );
+
+} else {
+
+    ok( utf8::is_utf8( $cd->title ), 'got title with utf8 flag' );
+    ok( !utf8::is_utf8( $cd->year ), 'got year without utf8 flag' );
+
+    utf8::decode($utf8_char);
+    $cd->title($utf8_char);
+    ok( !utf8::is_utf8( $cd->{_column_data}{title} ), 'store utf8-less chars' );
+}