From: Rafael Kitover Date: Tue, 13 Apr 2010 05:44:33 +0000 (-0400) Subject: minor improvement for MySQL X-Git-Tag: 0.07000~70 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=3372cb430e4c2642dc7c0fecf9bf41b1bf5c3faf;p=dbsrgits%2FDBIx-Class-Schema-Loader.git minor improvement for MySQL --- diff --git a/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm b/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm index 79515a7..db38ef9 100644 --- a/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm +++ b/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm @@ -38,9 +38,6 @@ sub _table_fk_info { my $dbh = $self->schema->storage->dbh; - local $dbh->{RaiseError} = 0; - local $dbh->{PrintError} = 0; - my $table_def_ref = eval { $dbh->selectrow_arrayref("SHOW CREATE TABLE `$table`") }; my $table_def = $table_def_ref->[1]; @@ -186,8 +183,8 @@ sub _extra_column_info { if ($dbi_info->{mysql_values}) { $extra_info{extra}{list} = $dbi_info->{mysql_values}; } - if ( $dbi_info->{COLUMN_DEF} =~ /^CURRENT_TIMESTAMP\z/i - && $dbi_info->{mysql_type_name} =~ /^TIMESTAMP\z/i) { + if ( lc($dbi_info->{COLUMN_DEF}) eq 'current_timestamp' + && lc($dbi_info->{mysql_type_name}) eq 'timestamp') { $extra_info{default_value} = \'CURRENT_TIMESTAMP'; }