From: Nicholas Clark <nick@ccl4.org>
Date: Thu, 9 Mar 2006 22:01:28 +0000 (+0000)
Subject: Superior *printf-fu lets us avoid modifying source code.
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=32d45c1d3bb497e6d65453056058531c637f7772;p=p5sagit%2Fp5-mst-13.2.git

Superior *printf-fu lets us avoid modifying source code.

p4raw-id: //depot/perl@27452
---

diff --git a/toke.c b/toke.c
index d87f7da..8ee3b84 100644
--- a/toke.c
+++ b/toke.c
@@ -1089,15 +1089,10 @@ S_check_uni(pTHX)
     if ((t = strchr(s, '(')) && t < PL_bufptr)
 	return;
 
-    /* XXX Things like this are just so nasty.  We shouldn't be modifying
-    source code, even if we realquick set it back. */
     if (ckWARN_d(WARN_AMBIGUOUS)){
-	const char ch = *s;
-        *s = '\0';
         Perl_warner(aTHX_ packWARN(WARN_AMBIGUOUS),
-		   "Warning: Use of \"%s\" without parentheses is ambiguous",
-		   PL_last_uni);
-        *s = ch;
+		   "Warning: Use of \"%.*s\" without parentheses is ambiguous",
+		   (int)(s - PL_last_uni), PL_last_uni);
     }
 }