From: David Mitchell Date: Sat, 20 Feb 2010 15:41:38 +0000 (+0000) Subject: unTODO some passing TODO tests in reg_fold.t X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=2f7760b5e56a54d737578924a8731d00fadf717c;p=p5sagit%2Fp5-mst-13.2.git unTODO some passing TODO tests in reg_fold.t As far as I can tell these particular tests were never actually TODO, but were lumped in with other failing tests for ease of coding the .t file --- diff --git a/t/re/reg_fold.t b/t/re/reg_fold.t index bbeaedd..1c7dfe8 100644 --- a/t/re/reg_fold.t +++ b/t/re/reg_fold.t @@ -11,6 +11,9 @@ use warnings; my $count=1; my @tests; +my %todo_pass = map { $_ => 1 } + qw(00DF 1E9E FB00 FB01 FB02 FB03 FB04 FB05 FB06); + my $file="../lib/unicore/CaseFolding.txt"; open my $fh,"<",$file or die "Failed to read '$file': $!"; while (<$fh>) { @@ -58,7 +61,9 @@ while (<$fh>) { $tests[-1]="TODO: { local \$::TODO='Multi-char, non-utf8 folded inside character class [ ] doesnt work';\n$tests[-1] }" } elsif (! $upgrade && $cpv >= 128 && $cpv <= 255 && $cpv != 0xb5) { $tests[-1]="TODO: { local \$::TODO='Most non-utf8 latin1 doesnt work';\n$tests[-1] }" - } elsif (! $swap && $charclass && @folded > 1) { + } elsif (! $swap && $charclass && @folded > 1 + && ! $todo_pass{$cp}) + { # There are a few of these that pass; most fail. $tests[-1]="TODO: { local \$::TODO='Some multi-char, f8 folded inside character class [ ] doesnt work';\n$tests[-1] }" }