From: Cinxgler Mariaca Minda Date: Tue, 4 Oct 2011 10:24:01 +0000 (+0100) Subject: little display fixes X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=2f5dbb7965e70421e9102802aab7d4a1757a35f4;hp=2eec441226ef866b1ce7d6e66d682ee78226b6a0;p=catagits%2FCatalystX-HelpText.git little display fixes --- diff --git a/lib/CatalystX/HelpText/Script/SearchUndocumentedHelpText.pm b/lib/CatalystX/HelpText/Script/SearchUndocumentedHelpText.pm index 1341335..109c5cf 100644 --- a/lib/CatalystX/HelpText/Script/SearchUndocumentedHelpText.pm +++ b/lib/CatalystX/HelpText/Script/SearchUndocumentedHelpText.pm @@ -42,16 +42,16 @@ has help_files_ext => ( sub run { my ($self) = @_; my $file_vs_keys = {}; - my @undocumented_keys = (); + my $undocumented_keys = {}; foreach my $fn ($self->find_files->flatten) { $file_vs_keys->{$fn} = $self->find_helptext_keys($fn); foreach my $key ($file_vs_keys->{$fn}->flatten) { unless ($self->is_there_helptext_file_for_key($key)) { - push @undocumented_keys, $key + $undocumented_keys->{$key} = 1; } } } - $self->print_result([ @undocumented_keys ], $file_vs_keys); + $self->print_result([ keys %$undocumented_keys ], $file_vs_keys); } sub find_files { @@ -94,8 +94,10 @@ sub is_there_helptext_file_for_key { sub print_result { my ($self, $undocumented_keys, $file_vs_keys) = @_; - print "Undocumented help text keys: \n"; - print " - $_" for ($undocumented_keys->flatten); + if (scalar @$undocumented_keys) { + print "Undocumented help text keys: \n"; + print " - $_" for ($undocumented_keys->flatten); + } } with qw/