From: Andy Lester <andy@petdance.com>
Date: Thu, 1 Dec 2005 14:24:51 +0000 (-0600)
Subject: Signs, signs, everywhere a sign
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=2d3e09341b1708b9d4e0982daf4d89d075ef0973;p=p5sagit%2Fp5-mst-13.2.git

Signs, signs, everywhere a sign
Message-ID: <20051201202451.GI22713@petdance.com>

p4raw-id: //depot/perl@26242
---

diff --git a/pp_pack.c b/pp_pack.c
index ca2795d..a7591de 100644
--- a/pp_pack.c
+++ b/pp_pack.c
@@ -2033,7 +2033,7 @@ S_unpack_rec(pTHX_ tempsym_t* symptr, const char *s, const char *strbeg, const c
 	    if (symptr->howlen == e_star)
 	        Perl_croak(aTHX_ "'P' must have an explicit size in unpack");
 	    EXTEND(SP, 1);
-	    if (sizeof(char*) <= strend - s) {
+	    if (s + sizeof(char*) <= strend) {
 		char *aptr;
 		SHIFT_VAR(utf8, s, strend, aptr, datumtype);
 		DO_BO_UNPACK_PC(aptr);
@@ -2125,9 +2125,9 @@ S_unpack_rec(pTHX_ tempsym_t* symptr, const char *s, const char *strbeg, const c
              * (and just as fast as doing character arithmetic)
              */
             if (PL_uudmap['M'] == 0) {
-                int i;
+		size_t i;
 
-                for (i = 0; i < sizeof(PL_uuemap); i += 1)
+		for (i = 0; i < sizeof(PL_uuemap); ++i)
                     PL_uudmap[(U8)PL_uuemap[i]] = i;
                 /*
                  * Because ' ' and '`' map to the same value,