From: Nick Ing-Simmons <nik@tiuk.ti.com>
Date: Fri, 3 May 2002 07:25:13 +0000 (+0000)
Subject: Several of non-default builds now seem to work reasonably well
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=2cbbe5a150b07f176547702112505e3d30ea082f;p=p5sagit%2Fp5-mst-13.2.git

Several of non-default builds now seem to work reasonably well
English.t seems to fail on an errno test, and socketpair blathers
about something.
Basic fix is to stop PERL_IMPLICIT_SYS turning on USE_PERLIO by the
back door, and instead have perlsdio.h vector stdio via iperlsys.h
function tables (latter was done in earlier change).
Update comments in Makefile.mk

p4raw-id: //depot/perlio@16367
---

diff --git a/perlio.h b/perlio.h
index 3105b58..172a806 100644
--- a/perlio.h
+++ b/perlio.h
@@ -40,7 +40,7 @@
 #if defined(PERL_IMPLICIT_SYS)
 #ifndef USE_PERLIO
 #ifndef NETWARE
-# define USE_PERLIO
+/* # define USE_PERLIO */
 #endif
 #endif
 #endif
diff --git a/win32/makefile.mk b/win32/makefile.mk
index 0c88b67..1eb7613 100644
--- a/win32/makefile.mk
+++ b/win32/makefile.mk
@@ -49,26 +49,30 @@ INST_ARCH	*= \$(ARCHNAME)
 
 #
 # uncomment to enable multiple interpreters.  This is need for fork()
-# emulation.
+# emulation and for thread support.
 #
 USE_MULTI	*= define
 
 #
-# Beginnings of interpreter cloning/threads; still very incomplete.
-# This should be enabled to get the fork() emulation.  This needs
-# USE_MULTI as well.
+# Interpreter cloning/threads; now reasonably complete.
+# This should be enabled to get the fork() emulation.  
+# This needs USE_MULTI above.
 #
 USE_ITHREADS	*= define
 
 #
 # uncomment to enable the implicit "host" layer for all system calls
-# made by perl.  This needs USE_MULTI above.  This is also needed to
-# get fork().
+# made by perl.  This needs USE_MULTI above.  
+# This is also needed to get fork().
 #
 USE_IMP_SYS	*= define
 
 #
-# Comment to disable I/O subsystem and use compiler's stdio for IO 
+# Comment out next assign to disable perl's I/O subsystem and use compiler's 
+# stdio for IO - depending on your compiler vendor and run time library you may 
+# then get a number of fails from make test i.e. bugs - complain to them not us ;-). 
+# You will also be unable to take full advantage of perl5.8's support for multiple 
+# encodings and may see lower IO performance. You have been warned.
 USE_PERLIO	= define
 
 #
@@ -112,7 +116,7 @@ CCTYPE		*= MSVC60
 # If not enabled, we automatically try to use maximum optimization
 # with all compilers that are known to have a working optimizer.
 #
-CFG		*= Debug
+#CFG		*= Debug
 
 #
 # uncomment to enable use of PerlCRT.DLL when using the Visual C compiler.
diff --git a/win32/win32.c b/win32/win32.c
index 4669d3a..f72acdd 100644
--- a/win32/win32.c
+++ b/win32/win32.c
@@ -2643,6 +2643,7 @@ win32_popen(const char *command, const char *mode)
 #ifdef USE_RTL_POPEN
     return _popen(command, mode);
 #else
+    dTHX;
     int p[2];
     int parent, child;
     int stdfd, oldfd;