From: Jess Robinson Date: Thu, 9 Oct 2008 18:49:40 +0000 (+0000) Subject: Skip on newer Spreadsheet::ParseExcel X-Git-Tag: v0.11008~296 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=2c273e34cd2ad505f596859bdfc4e1e852529b86;p=dbsrgits%2FSQL-Translator.git Skip on newer Spreadsheet::ParseExcel Add new oracle bits to MANIFEST --- diff --git a/MANIFEST b/MANIFEST index 0636be5..cd08418 100644 --- a/MANIFEST +++ b/MANIFEST @@ -139,6 +139,8 @@ t/49xml-to-pg-samefield.t t/52-oracle-options.t t/53-oracle-delay-constraints.t t/54-oracle-alter-field.t +t/55-oracle-add-field.t +t/56-sqlite-producer.t t/data/access/gdpdm.ddl t/data/Excel/t.xls t/data/oracle/create.sql @@ -146,6 +148,7 @@ t/data/oracle/create2.sql t/data/oracle/schema_with_options.yaml t/data/oracle/schema_diff_a.yaml t/data/oracle/schema_diff_b.yaml +t/data/oracle/schema_diff_c.yaml t/data/mysql/Apache-Session-MySQL.sql t/data/mysql/BGEP-RE-create.sql t/data/mysql/create.sql diff --git a/t/10excel.t b/t/10excel.t index 0414d94..4321af4 100644 --- a/t/10excel.t +++ b/t/10excel.t @@ -43,10 +43,16 @@ is( $f3->size, 1, 'Size is "1"' ); is( $f3->is_primary_key, 0, 'Field is not PK' ); my $f4 = shift @fields; -is( $f4->name, 'math', 'Fourth field name is "math"' ); -is( lc $f4->data_type, 'float', 'Data type is "float"' ); -is( $f4->size, '3,1', 'Size is "3,1"' ); -is( $f4->is_primary_key, 0, 'Field is not PK' ); +TODO: { + eval { require Spreadsheet::ParseExcel }; + todo_skip "Bug in Spreadsheet::ParseExcel, http://rt.cpan.org/Public/Bug/Display.html?id=39892", 4 + if ($Spreadsheet::ParseExcel::VERSION > 0.32); + + is( $f4->name, 'math', 'Fourth field name is "math"' ); + is( lc $f4->data_type, 'float', 'Data type is "float"' ); + is( $f4->size, '3,1', 'Size is "3,1"' ); + is( $f4->is_primary_key, 0, 'Field is not PK' ); +} my $f5 = shift @fields; is( $f5->name, 'bitmap', 'Fifth field name is "bitmap"' );