From: Rafael Kitover <rkitover@cpan.org>
Date: Tue, 2 Feb 2010 22:02:29 +0000 (+0000)
Subject: DT inflation now works
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=2b0076be05baf00b0b4928a237ab43f377233fd4;p=dbsrgits%2FDBIx-Class-Historic.git

DT inflation now works
---

diff --git a/lib/DBIx/Class/Storage/DBI/SQLAnywhere.pm b/lib/DBIx/Class/Storage/DBI/SQLAnywhere.pm
index 207330e..623a8e1 100644
--- a/lib/DBIx/Class/Storage/DBI/SQLAnywhere.pm
+++ b/lib/DBIx/Class/Storage/DBI/SQLAnywhere.pm
@@ -12,7 +12,7 @@ __PACKAGE__->mk_group_accessors(simple => qw/
 
 =head1 NAME
 
-DBIx::Class::Storage::DBI::Sybase::ASA - Driver for Sybase SQL Anywhere
+DBIx::Class::Storage::DBI::SQLAnywhere - Driver for Sybase SQL Anywhere
 
 =head1 DESCRIPTION
 
@@ -22,7 +22,13 @@ RowNumberOver limit implementation.
 You need the C<DBD::SQLAnywhere> driver that comes with the SQL Anywhere
 distribution, B<NOT> the one on CPAN. It is usually under a path such as:
 
-    /opt/sqlanywhere11/sdk/perl
+  /opt/sqlanywhere11/sdk/perl
+
+Recommended L<DBIx::Class::Storage::DBI/connect_info> settings:
+
+  on_connect_call => 'datetime_setup'
+
+=head1 METHODS
 
 =cut
 
@@ -57,7 +63,7 @@ sub insert {
   return $self->next::method(@_);
 }
 
-# stolen from DB2
+# this sub stolen from DB2
 
 sub _sql_maker_opts {
   my ( $self, $opts ) = @_;
@@ -69,6 +75,48 @@ sub _sql_maker_opts {
   return { limit_dialect => 'RowNumberOver', %{$self->{_sql_maker_opts}||{}} };
 }
 
+# this sub stolen from MSSQL
+
+sub build_datetime_parser {
+  my $self = shift;
+  my $type = "DateTime::Format::Strptime";
+  eval "use ${type}";
+  $self->throw_exception("Couldn't load ${type}: $@") if $@;
+  return $type->new( pattern => '%Y-%m-%d %H:%M:%S.%6N' );
+}
+
+=head2 connect_call_datetime_setup
+
+Used as:
+
+    on_connect_call => 'datetime_setup'
+
+In L<DBIx::Class::Storage::DBI/connect_info> to set the date and timestamp
+formats (as temporary options for the session) for use with
+L<DBIx::Class::InflateColumn::DateTime>.
+
+The C<TIMESTAMP> data type supports up to 6 digits after the decimal point for
+second precision. The full precision is used.
+
+The C<DATE> data type supposedly stores hours and minutes too, according to the
+documentation, but I could not get that to work. It seems to only store the
+date.
+
+You will need the L<DateTime::Format::Strptime> module for inflation to work.
+
+=cut
+
+sub connect_call_datetime_setup {
+  my $self = shift;
+
+  $self->_do_query(
+    "set temporary option timestamp_format = 'yyyy-mm-dd hh:mm:ss.ssssss'"
+  );
+  $self->_do_query(
+    "set temporary option date_format      = 'yyyy-mm-dd hh:mm:ss.ssssss'"
+  );
+}
+
 1;
 
 =head1 AUTHOR
diff --git a/t/inflate/datetime_sybase_asa.t b/t/inflate/datetime_sybase_asa.t
index 387b179..d027c47 100644
--- a/t/inflate/datetime_sybase_asa.t
+++ b/t/inflate/datetime_sybase_asa.t
@@ -13,9 +13,9 @@ if (not $dsn) {
     'Set $ENV{DBICTEST_SYBASE_ASA_DSN}, _USER and _PASS to run this test' .
     "\nWarning: This test drops and creates a table called 'track'";
 } else {
-  eval "use DateTime; use DateTime::Format::Sybase;";
+  eval "use DateTime; use DateTime::Format::Strptime;";
   if ($@) {
-    plan skip_all => 'needs DateTime and DateTime::Format::Sybase for testing';
+    plan skip_all => 'needs DateTime and DateTime::Format::Strptime for testing';
   }
 }
 
@@ -24,15 +24,14 @@ my $schema;
 $schema = DBICTest::Schema->clone;
 
 $schema->connection($dsn, $user, $pass, {
-  AutoCommit => 1,
   on_connect_call => [ 'datetime_setup' ],
 });
 
 # coltype, col, date
 my @dt_types = (
-  ['DATETIME', 'last_updated_at', '2004-08-21T14:36:48.080Z'],
-# minute precision
-  ['SMALLDATETIME', 'small_dt', '2004-08-21T14:36:00.000Z'],
+  ['TIMESTAMP', 'last_updated_at', '2004-08-21 14:36:48.080444'],
+# date only (but minute precision according to ASA docs)
+  ['DATE', 'small_dt', '2004-08-21 00:00:00.000000'],
 );
 
 for my $dt_type (@dt_types) {
@@ -47,7 +46,7 @@ CREATE TABLE track (
   $col $type,
 )
 SQL
-  ok(my $dt = DateTime::Format::Sybase->parse_datetime($sample_dt));
+  ok(my $dt = $schema->storage->datetime_parser->parse_datetime($sample_dt));
 
   my $row;
   ok( $row = $schema->resultset('Track')->create({