From: Norbert Buchmuller <norbi@nix.hu>
Date: Tue, 11 Nov 2008 06:00:18 +0000 (+0100)
Subject:  * Removed a wrong TODO test: "order_by with quoting needs fixing (ash/castaway)... 
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=2924125de8a55ac8adc21912039a874e8324dfe9;p=dbsrgits%2FDBIx-Class-Historic.git

 * Removed a wrong TODO test: "order_by with quoting needs fixing (ash/castaway)" (asked by mst).
 * Made a TODO test non-TODO: "select attr with star needs fixing (mst/nate)" (works with SQLA 1.50).
---

diff --git a/t/95sql_maker_quote.t b/t/95sql_maker_quote.t
index 7f8b72c..626cd49 100644
--- a/t/95sql_maker_quote.t
+++ b/t/95sql_maker_quote.t
@@ -9,7 +9,7 @@ BEGIN {
     eval "use DBD::SQLite";
     plan $@
         ? ( skip_all => 'needs DBD::SQLite for testing' )
-        : ( tests => 8 );
+        : ( tests => 7 );
 }
 
 use lib qw(t/lib);
@@ -78,38 +78,26 @@ is_same_sql_bind(
           undef
 );
 
-TODO: {
-    local $TODO = "order_by with quoting needs fixing (ash/castaway)";
-
-    is($sql, 
-       q/SELECT `me`.`cdid`, `me`.`artist`, `me`.`title`, `me`.`year` FROM `cd` `me` ORDER BY `year` DESC/, 
-       'quoted ORDER BY with DESC okay');
-}
-
-TODO: {
-    local $TODO = "select attr with star needs fixing (mst/nate)";
+($sql, @bind) = $sql_maker->select(
+      [
+        {
+          'me' => 'cd'
+        }
+      ],
+      [
+        'me.*'
+      ],
+      undef,
+      [],
+      undef,
+      undef    
+);
 
-    ($sql, @bind) = $sql_maker->select(
-          [
-            {
-              'me' => 'cd'
-            }
-          ],
-          [
-            'me.*'
-          ],
-          undef,
-          [],
-          undef,
-          undef    
-    );
-
-    is_same_sql_bind(
-      $sql, \@bind,
-      q/SELECT `me`.* FROM `cd` `me`/, [],
-      'select attr with me.* is right'
-    );
-}
+is_same_sql_bind(
+  $sql, \@bind,
+  q/SELECT `me`.* FROM `cd` `me`/, [],
+  'select attr with me.* is right'
+);
 
 ($sql, @bind) = $sql_maker->select(
           [