From: Dagfinn Ilmari Mannsåker Date: Fri, 29 Jul 2016 14:43:11 +0000 (+0100) Subject: Fix "overriden" typo X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=2781bf350385459d9da6a511a9ef776d41e5f93d;p=dbsrgits%2FDBIx-Class.git Fix "overriden" typo --- diff --git a/lib/DBIx/Class/MethodAttributes.pm b/lib/DBIx/Class/MethodAttributes.pm index 8dfb072..9bf5a2d 100644 --- a/lib/DBIx/Class/MethodAttributes.pm +++ b/lib/DBIx/Class/MethodAttributes.pm @@ -274,7 +274,7 @@ in a Result class and "hope for the best". The subtle changes of various internal call-chains in C make this silent uncertainty untenable. As a solution any such override will now issue a descriptive warning that it has been bypassed during a -C<< $rsrc->overriden_function >> invocation. A user B determine how +C<< $rsrc->overridden_function >> invocation. A user B determine how each individual override must behave in this situation, and tag it with one of the above two attributes. diff --git a/lib/DBIx/Class/ResultSource.pm b/lib/DBIx/Class/ResultSource.pm index 9470546..4d33970 100644 --- a/lib/DBIx/Class/ResultSource.pm +++ b/lib/DBIx/Class/ResultSource.pm @@ -457,7 +457,7 @@ sub __emit_stale_metadata_diag { =head2 clone - $rsrc_instance->clone( atribute_name => overriden_value ); + $rsrc_instance->clone( atribute_name => overridden_value ); A wrapper around L inheriting any defaults from the callee. This method also not normally invoked directly by end users. diff --git a/lib/DBIx/Class/Schema/SanityChecker.pm b/lib/DBIx/Class/Schema/SanityChecker.pm index 481d0f7..b048edd 100644 --- a/lib/DBIx/Class/Schema/SanityChecker.pm +++ b/lib/DBIx/Class/Schema/SanityChecker.pm @@ -341,8 +341,8 @@ sub format_no_indirect_method_overrides_errors { . "chain of calls within the convenience shortcut as seen when running:\n " . '~$ perl -M%2$s -MDevel::Dwarn -e "Ddie { %3$s => %2$s->can(q(%3$s)) }"', join (', ', map { "$_()" } sort @{ $_->{by} } ), - $_->{overriden}{via_class}, - $_->{overriden}{name}, + $_->{overridden}{via_class}, + $_->{overridden}{name}, )} @{ $_[1] } ] } @@ -364,7 +364,7 @@ sub check_no_indirect_method_overrides { unless $_->{attributes}{DBIC_method_is_indirect_sugar}; push @err, { - overriden => { + overridden => { name => $_->{name}, via_class => ( # this way we report a much better Dwarn oneliner in the error