From: Barrie Slaymaker <barries@slaysys.com>
Date: Sun, 3 Oct 1999 00:09:51 +0000 (-0400)
Subject: Benchmark.pm bugfix, tweaks
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=277427cf4e56f8c457d0805b2bd9ffb88d75e5a5;p=p5sagit%2Fp5-mst-13.2.git

Benchmark.pm bugfix, tweaks

To: perl5-porters@perl.org
Message-Id: <199910030409.AAA18228@jester.slaysys.com>

p4raw-id: //depot/cfgperl@4292
---

diff --git a/lib/Benchmark.pm b/lib/Benchmark.pm
index 08caa48..9196673 100644
--- a/lib/Benchmark.pm
+++ b/lib/Benchmark.pm
@@ -198,14 +198,14 @@ Clear all cached times.
 =item cmpthese ( RESULTSHASHREF )
 
 Optionally calls timethese(), then outputs comparison chart.  This 
-chart is sorted from slowest to highest, and shows the percent 
+chart is sorted from slowest to fastest, and shows the percent 
 speed difference between each pair of tests.  Can also be passed 
 the data structure that timethese() returns:
 
     $results = timethese( .... );
     cmpthese( $results );
 
-Returns the data structure returned by timethese().
+Returns the data structure returned by timethese() (or passed in).
 
 =item countit(TIME, CODE)
 
@@ -444,9 +444,7 @@ sub runloop {
     # in &countit.  This, in turn, can reduce the number of calls to
     # &runloop a lot, and thus reduce additive errors.
     my $tbase = Benchmark->new(0)->[1];
-    do {
-       $t0 = Benchmark->new(0);
-    } while ( $t0->[1] == $tbase );
+    while ( ( $t0 = Benchmark->new(0) )->[1] == $tbase ) {} ;
     &$subref;
     $t1 = Benchmark->new($n);
     $td = &timediff($t1, $t0);
@@ -729,7 +727,7 @@ sub cmpthese{
        sort { $$a <=> $$b } map { \$_ } @col_widths[2..$#col_widths];
     my $max_width = ${$sorted_width_refs[-1]};
 
-    my $total = 0;
+    my $total = @col_widths - 1 ;
     for ( @col_widths ) { $total += $_ }
 
     STRETCHER: