From: Peter Rabbitson Date: Thu, 11 Jun 2009 16:26:40 +0000 (+0000) Subject: Merge 'trunk' into 'mssql_top_fixes' X-Git-Tag: v0.08108~12^2~40 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=26afdab69f79a24654f7c8c42157ddab105b7929;p=dbsrgits%2FDBIx-Class.git Merge 'trunk' into 'mssql_top_fixes' r6557@Thesaurus (orig r6556): ash | 2009-06-09 12:20:34 +0200 Addjust bug to show problem with rows => 1 + child rel r6558@Thesaurus (orig r6557): ribasushi | 2009-06-09 13:12:46 +0200 Require a recent bugfixed Devel::Cycle r6560@Thesaurus (orig r6559): ash | 2009-06-09 15:07:30 +0200 Make IC::DT extra warning state the column name too r6575@Thesaurus (orig r6574): ribasushi | 2009-06-10 00:19:48 +0200 AuthorCheck fixes r6579@Thesaurus (orig r6578): ribasushi | 2009-06-10 00:52:17 +0200 r6522@Thesaurus (orig r6521): ribasushi | 2009-06-05 19:27:55 +0200 New branch to try resultsource related stuff r6545@Thesaurus (orig r6544): ribasushi | 2009-06-08 13:00:54 +0200 First stab at adding resultsources to each join in select - works won-der-ful-ly r6546@Thesaurus (orig r6545): ribasushi | 2009-06-08 13:14:08 +0200 Commit failing test and thoughts on search arg deflation r6576@Thesaurus (orig r6575): ribasushi | 2009-06-10 00:31:55 +0200 Todoify DT in search deflation test until after 0.09 r6577@Thesaurus (orig r6576): ribasushi | 2009-06-10 00:48:07 +0200 Factor out the $ident resolver r6581@Thesaurus (orig r6580): ribasushi | 2009-06-10 01:21:50 +0200 Move as_query out of the cursor r6582@Thesaurus (orig r6581): ribasushi | 2009-06-10 01:27:19 +0200 Think before commit r6583@Thesaurus (orig r6582): ribasushi | 2009-06-10 09:37:19 +0200 Clarify and disable rows/prefetch test - fix is easy, but architecturally unsound - need more time r6591@Thesaurus (orig r6590): ribasushi | 2009-06-10 13:33:37 +0200 r6544@Thesaurus (orig r6543): ribasushi | 2009-06-08 11:44:59 +0200 Attempt to figure out why do we repeat joins on complex search_related r6586@Thesaurus (orig r6585): ribasushi | 2009-06-10 11:22:05 +0200 Move the rs preservation test to a more suitable place r6589@Thesaurus (orig r6588): ribasushi | 2009-06-10 13:15:48 +0200 Finally commit trully failing test r6590@Thesaurus (orig r6589): ribasushi | 2009-06-10 13:33:14 +0200 Duh, this was a pretty simple bug r6593@Thesaurus (orig r6592): ribasushi | 2009-06-10 13:43:31 +0200 What was I thinking - resultsource does not have an ->alias r6598@Thesaurus (orig r6597): ribasushi | 2009-06-10 14:48:39 +0200 Adjust changelog r6601@Thesaurus (orig r6600): ribasushi | 2009-06-10 15:50:43 +0200 Release 0.08104 r6615@Thesaurus (orig r6614): ribasushi | 2009-06-11 14:29:48 +0200 Move around inflation tests r6616@Thesaurus (orig r6615): ribasushi | 2009-06-11 14:32:07 +0200 explicitly remove manifest on author mode make r6617@Thesaurus (orig r6616): ribasushi | 2009-06-11 15:02:41 +0200 IC::DT changes: Switch SQLite storage to DT::F::SQLite Fix exception when undef_if_invalid and timezone are both set on a column Split t/89inflate_datetime into separate tests Adjust makefile author dependencies r6618@Thesaurus (orig r6617): ribasushi | 2009-06-11 15:07:41 +0200 Move file_column test to inflate/ too r6621@Thesaurus (orig r6620): ribasushi | 2009-06-11 16:16:20 +0200 r5713@Thesaurus (orig r5712): ribasushi | 2009-03-08 23:53:28 +0100 Branch for datatype-aware updates r6604@Thesaurus (orig r6603): ribasushi | 2009-06-10 18:08:25 +0200 Test for type-aware update r6607@Thesaurus (orig r6606): ribasushi | 2009-06-10 19:57:04 +0200 Datatype aware update works r6609@Thesaurus (orig r6608): ribasushi | 2009-06-10 20:06:40 +0200 Whoops r6614@Thesaurus (orig r6613): ribasushi | 2009-06-11 09:23:54 +0200 Add attribute doc r6620@Thesaurus (orig r6619): ribasushi | 2009-06-11 16:15:53 +0200 Use equality, not comparison r6623@Thesaurus (orig r6622): ribasushi | 2009-06-11 16:21:53 +0200 Changes --- 26afdab69f79a24654f7c8c42157ddab105b7929 diff --cc lib/DBIx/Class/Storage/DBI.pm index 2e855e2,c6f13f5..bff3800 --- a/lib/DBIx/Class/Storage/DBI.pm +++ b/lib/DBIx/Class/Storage/DBI.pm @@@ -1091,9 -1123,9 +1123,9 @@@ sub update sub delete { my $self = shift @_; my $source = shift @_; - + - my $bind_attrs = {}; ## If ever it's needed... + my $bind_attrs = $self->source_bind_attributes($source); - + return $self->_execute('delete' => [], $source, $bind_attrs, @_); }