From: Peter Rabbitson <ribasushi@cpan.org>
Date: Wed, 7 Oct 2015 17:42:23 +0000 (+0200)
Subject: Explicitly document the late runtime binding of `sort SUBNAME ...`
X-Git-Tag: 0.26~1
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=253c58bc721609f0590be3149ebd77802d7371df;p=p5sagit%2Fnamespace-clean.git

Explicitly document the late runtime binding of `sort SUBNAME ...`
---

diff --git a/Changes b/Changes
index bb2043a..417f311 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,8 @@
         - Exclusively use Package::Stash::PP on perls < 5.8.7 until a fixed
           Package::Stash::XS ships - breakage keeps getting reintroduced
           ( RT#107343, RT#74151 )
+        - Explicitly document the late runtime binding of `sort SUBNAME ...`
+          ( RT#101247 )
         - No longer rely on Sub::Identify - either use Sub::Util or B
           ( should solve RT#96945 )
 
diff --git a/lib/namespace/clean.pm b/lib/namespace/clean.pm
index e80413b..e53c26e 100644
--- a/lib/namespace/clean.pm
+++ b/lib/namespace/clean.pm
@@ -287,6 +287,30 @@ be a module exporting an C<import> method along with some functions:
 If you just want to C<-except> a single sub, you can pass it directly.
 For more than one value you have to use an array reference.
 
+=head3 Late binding caveat
+
+Note that the L<technique used by this module|/IMPLEMENTATION DETAILS> relies
+on perl having resolved all names to actual code references during the
+compilation of a scope. While this is almost always what the interpreter does,
+there are some exceptions, notably the L<sort SUBNAME|perlfunc/sort> style of
+the C<sort> built-in invocation. The following example will not work, because
+C<sort> does not try to resolve the function name to an actual code reference
+until B<runtime>.
+
+ use MyApp::Utils 'my_sorter';
+ use namespace::clean;
+
+ my @sorted = sort my_sorter @list;
+
+You need to work around this by forcing a compile-time resolution like so:
+
+ use MyApp::Utils 'sorter';
+ use namespace::clean;
+
+ my $my_sorter_cref = \&sorter;
+
+ my @sorted = sort $my_sorter_cref @list;
+
 =head2 Explicitly removing functions when your scope is compiled
 
 It is also possible to explicitly tell C<namespace::clean> what packages