From: Peter Rabbitson <ribasushi@cpan.org>
Date: Tue, 27 May 2014 05:53:38 +0000 (+0200)
Subject: Reaching for IO::File here makes no sense
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=238e071106f84eb98f001e8d14b27ae600119a28;p=dbsrgits%2FDBIx-Class-Historic.git

Reaching for IO::File here makes no sense
---

diff --git a/lib/DBIx/Class/Storage/Statistics.pm b/lib/DBIx/Class/Storage/Statistics.pm
index 7e491cd..6c77ffb 100644
--- a/lib/DBIx/Class/Storage/Statistics.pm
+++ b/lib/DBIx/Class/Storage/Statistics.pm
@@ -3,7 +3,6 @@ use strict;
 use warnings;
 
 use base qw/DBIx::Class/;
-use IO::File;
 use namespace::clean;
 
 __PACKAGE__->mk_group_accessors(simple => qw/callback _debugfh silence/);
@@ -61,11 +60,11 @@ sub debugfh {
     my $debug_env = $ENV{DBIX_CLASS_STORAGE_DBI_DEBUG}
                   || $ENV{DBIC_TRACE};
     if (defined($debug_env) && ($debug_env =~ /=(.+)$/)) {
-      $fh = IO::File->new($1, 'a')
-        or die("Cannot open trace file $1");
+      open ($fh, '>>', $1)
+        or die("Cannot open trace file $1: $!");
     } else {
-      $fh = IO::File->new('>&STDERR')
-        or die('Duplication of STDERR for debug output failed (perhaps your STDERR is closed?)');
+      open ($fh, '>&STDERR')
+        or die("Duplication of STDERR for debug output failed (perhaps your STDERR is closed?): $!");
     }
 
     $fh->autoflush();