From: Nicholas Clark <nick@ccl4.org>
Date: Wed, 9 Nov 2005 10:56:28 +0000 (+0000)
Subject: Remove superfluous strlen() from pp_require().
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=238d24b47319609016b1ceeca1f7146f7484b9a0;p=p5sagit%2Fp5-mst-13.2.git

Remove superfluous strlen() from pp_require().

p4raw-id: //depot/perl@26059
---

diff --git a/pp_ctl.c b/pp_ctl.c
index 71afbda..ed64242 100644
--- a/pp_ctl.c
+++ b/pp_ctl.c
@@ -3313,10 +3313,8 @@ PP(pp_require)
     else
 	SETERRNO(0, SS_NORMAL);
 
-    /* FIXME - is name ever assigned to after the SvPVX_const that also set
-       len?  If no, then this strlen() is superfluous.  */
     /* Assume success here to prevent recursive requirement. */
-    len = strlen(name);
+    /* name is never assigned to again, so len is still strlen(name)  */
     /* Check whether a hook in @INC has already filled %INC */
     if (!hook_sv) {
 	(void)hv_store(GvHVn(PL_incgv), name, len, newSVpv(CopFILE(&PL_compiling),0),0);