From: Jarkko Hietaniemi <jhi@iki.fi>
Date: Sat, 27 Jan 2001 00:35:47 +0000 (+0000)
Subject: No point in checking the length before we know whether the pointer
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=22c522dff2af214d7ac14a8885bb5f213c997ba5;p=p5sagit%2Fp5-mst-13.2.git

No point in checking the length before we know whether the pointer
is bogus or not, fixes Abigail's odbm failures in Linux.

p4raw-id: //depot/perl@8555
---

diff --git a/sv.c b/sv.c
index 93188df..ed7ebdc 100644
--- a/sv.c
+++ b/sv.c
@@ -3530,16 +3530,17 @@ void
 Perl_sv_setpvn(pTHX_ register SV *sv, register const char *ptr, register STRLEN len)
 {
     register char *dptr;
-    {
-        /* len is STRLEN which is unsigned, need to copy to signed */
-	IV iv = len;
-	assert(iv >= 0);
-    }
+
     SV_CHECK_THINKFIRST(sv);
     if (!ptr) {
 	(void)SvOK_off(sv);
 	return;
     }
+    else {
+        /* len is STRLEN which is unsigned, need to copy to signed */
+	IV iv = len;
+	assert(iv >= 0);
+    }
     (void)SvUPGRADE(sv, SVt_PV);
 
     SvGROW(sv, len + 1);