From: Nicholas Clark <nick@ccl4.org>
Date: Fri, 28 Dec 2001 00:43:02 +0000 (+0000)
Subject: because (sys)?read doesn't reset buffers
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=229548006a555a22de8bd63ff251956b5a6f7aa4;p=p5sagit%2Fp5-mst-13.2.git

because (sys)?read doesn't reset buffers
Message-ID: <20011228004301.B23373@Bagpuss.unfortu.net>

p4raw-id: //depot/perl@13913
---

diff --git a/ext/Socket/socketpair.t b/ext/Socket/socketpair.t
index d2558dc..c31e4df 100644
--- a/ext/Socket/socketpair.t
+++ b/ext/Socket/socketpair.t
@@ -60,9 +60,11 @@ foreach (@right) {
 # stream socket, so our writes will become joined:
 my ($buffer, $expect);
 $expect = join '', @right;
+undef $buffer;
 is (read (LEFT, $buffer, length $expect), length $expect, "read on left");
 is ($buffer, $expect, "content what we expected?");
 $expect = join '', @left;
+undef $buffer;
 is (read (RIGHT, $buffer, length $expect), length $expect, "read on right");
 is ($buffer, $expect, "content what we expected?");
 
@@ -99,6 +101,7 @@ foreach (@gripping) {
 ok (!eof LEFT, "left is not at EOF");
 
 $expect = join '', @gripping;
+undef $buffer;
 is (read (LEFT, $buffer, length $expect), length $expect, "read on left");
 is ($buffer, $expect, "content what we expected?");
 
@@ -126,11 +129,13 @@ foreach (@right) {
 my ($total);
 $total = join '', @right;
 foreach $expect (@right) {
+  undef $buffer;
   is (sysread (LEFT, $buffer, length $total), length $expect, "read on left");
   is ($buffer, $expect, "content what we expected?");
 }
 $total = join '', @left;
 foreach $expect (@left) {
+  undef $buffer;
   is (sysread (RIGHT, $buffer, length $total), length $expect, "read on right");
   is ($buffer, $expect, "content what we expected?");
 }
@@ -144,6 +149,7 @@ ok (shutdown(LEFT, 1), "shutdown left for writing");
   local $SIG{ALRM} = sub { $alarmed = 1; };
   print "# Approximate forever as 3 seconds. Wait 'forever'...\n";
   alarm 3;
+  undef $buffer;
   is (sysread (RIGHT, $buffer, 1), undef,
       "read on right should be interrupted");
   is ($alarmed, 1, "alarm should have fired");
@@ -158,6 +164,7 @@ foreach (@gripping) {
 
 $total = join '', @gripping;
 foreach $expect (@gripping) {
+  undef $buffer;
   is (sysread (LEFT, $buffer, length $total), length $expect, "read on left");
   is ($buffer, $expect, "content what we expected?");
 }