From: Peter Rabbitson Date: Tue, 20 Mar 2012 03:12:06 +0000 (+0100) Subject: Remove todoified tests reflecting a conceptual brainfart X-Git-Tag: v0.08197~78 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=2112fa3bca913f9340c6d315ab333a9dc36b1726;p=dbsrgits%2FDBIx-Class.git Remove todoified tests reflecting a conceptual brainfart --- diff --git a/t/746mssql.t b/t/746mssql.t index 71f49a2..bafbef2 100644 --- a/t/746mssql.t +++ b/t/746mssql.t @@ -278,35 +278,6 @@ SQL ); } - { - my $book_owner_ids = $schema->resultset ('BooksInLibrary')->search ({}, { - rows => 6, - offset => 2, - join => 'owner', - distinct => 1, - order_by => 'owner.name', - unsafe_subselect_ok => 1 - })->get_column ('owner'); - - my @ids = $book_owner_ids->all; - - is (@ids, 6, 'Limit works'); - - my $book_owners = $schema->resultset ('Owners')->search ({ - id => { -in => $book_owner_ids->as_query } - }); - - TODO: { - local $TODO = "Correlated limited IN subqueries will probably never preserve order"; - - is_deeply ( - [ map { $_->id } ($book_owners->all) ], - [ $book_owner_ids->all ], - "$test_type: Sort is preserved across IN subqueries", - ); - } - } - # still even with lost order of IN, we should be getting correct # sets {