From: Peter Rabbitson Date: Thu, 10 Jan 2013 14:03:05 +0000 (+0100) Subject: deployment_statements() is not storage-dependent - only sqlt_type() is X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=1f9712ad52d92dd562fcda6e1846370d45342a13;p=dbsrgits%2FDBIx-Class-Historic.git deployment_statements() is not storage-dependent - only sqlt_type() is This fixes maint/gen_schema erroring out after 75d3bdb243 --- diff --git a/lib/DBIx/Class/Storage/DBI.pm b/lib/DBIx/Class/Storage/DBI.pm index becaf2b..a9a8381 100644 --- a/lib/DBIx/Class/Storage/DBI.pm +++ b/lib/DBIx/Class/Storage/DBI.pm @@ -87,7 +87,6 @@ sub _determine_supports_join_optimizer { 1 }; # class, as _use_X may be hardcoded class-wide, and _supports_X calls # _determine_supports_X which obv. needs a correct driver as well my @rdbms_specific_methods = qw/ - deployment_statements sqlt_type sql_maker build_datetime_parser diff --git a/t/105view_deps.t b/t/105view_deps.t index 284fb4a..21aa92b 100644 --- a/t/105view_deps.t +++ b/t/105view_deps.t @@ -37,7 +37,7 @@ can_ok( $view, $_ ) for qw/new from deploy_depends_on/; #################### DEPLOY - $schema->deploy( { add_drop_table => 1 } ); + $schema->deploy; #################### DOES ORDERING WORK? @@ -75,7 +75,7 @@ can_ok( $view, $_ ) for qw/new from deploy_depends_on/; #################### DEPLOY2 - warnings_exist { $schema2->deploy( { add_drop_table => 1 } ) } + warnings_exist { $schema2->deploy } [qr/no such table: main.aba_name_artists/], "Deploying the bad schema produces a warning: aba_name_artists was not created.";