From: Peter Rabbitson Date: Fri, 13 Feb 2009 10:45:46 +0000 (+0000) Subject: Some forgotten tests X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=1f5bf3246dd2046c2979b1c59af36fd152aaab85;p=dbsrgits%2FDBIx-Class-Historic.git Some forgotten tests --- diff --git a/t/86sqlt.t b/t/86sqlt.t index 4b00fda..24d573e 100644 --- a/t/86sqlt.t +++ b/t/86sqlt.t @@ -10,7 +10,7 @@ plan skip_all => 'SQL::Translator required' if $@; my $schema = DBICTest->init_schema; -plan tests => 132; +plan tests => 133; my $translator = SQL::Translator->new( parser_args => { @@ -29,7 +29,7 @@ my $translator = SQL::Translator->new( $schema->source('Track')->sqlt_deploy_callback(sub { my ($self, $sqlt_table) = @_; - if ($sqlt_table->schema->translator->producer_type =~ /SQLite$/ ) { + if ($schema->storage->sqlt_type eq 'SQLite' ) { $sqlt_table->add_index( name => 'track_title', fields => ['title'] ) or die $sqlt_table->error; } @@ -282,6 +282,18 @@ my $tschema = $translator->schema(); # the 'dummy' table ok( !defined($tschema->get_table('dummy')), "Dummy table was removed by hook"); +# Test that the Artist resultsource sqlt_deploy_hook was called okay and added +# an index +SKIP: { + skip ('Artist sqlt_deploy_hook is only called with an SQLite backend', 1) + if $schema->storage->sqlt_type ne 'SQLite'; + + ok( ( grep + { $_->name eq 'artist_name_hookidx' } + $tschema->get_table('artist')->get_indices + ), 'sqlt_deploy_hook fired within a resultsource'); +} + # Test that nonexistent constraints are not found my $constraint = get_constraint('FOREIGN KEY', 'cd', ['title'], 'cd', ['year']); ok( !defined($constraint), 'nonexistent FOREIGN KEY constraint not found' ); diff --git a/t/lib/DBICTest/Schema/Artist.pm b/t/lib/DBICTest/Schema/Artist.pm index c772c5b..c575374 100644 --- a/t/lib/DBICTest/Schema/Artist.pm +++ b/t/lib/DBICTest/Schema/Artist.pm @@ -56,9 +56,8 @@ __PACKAGE__->has_many( sub sqlt_deploy_hook { my ($self, $sqlt_table) = @_; - if ($sqlt_table->schema->translator->producer_type =~ /SQLite$/ ) { - $sqlt_table->add_index( name => 'artist_name', fields => ['name'] ) + $sqlt_table->add_index( name => 'artist_name_hookidx', fields => ['name'] ) or die $sqlt_table->error; } }