From: Steve Peters <steve@fisharerojo.org>
Date: Wed, 7 Dec 2005 02:10:26 +0000 (+0000)
Subject: Upgrade to CGI-3.14.
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=1f42692825f0c2ae2aff7c8dc9679ad797e3f97c;p=p5sagit%2Fp5-mst-13.2.git

Upgrade to CGI-3.14.

       Mmm...pi.  Oh, also including some Pod fixes in bleadperl that haven't
       yet been applied to the actual CGI distribution yet.

p4raw-id: //depot/perl@26288
---

diff --git a/lib/CGI.pm b/lib/CGI.pm
index 27ca5bb..bd3488e 100644
--- a/lib/CGI.pm
+++ b/lib/CGI.pm
@@ -18,8 +18,8 @@ use Carp 'croak';
 # The most recent version and complete docs are available at:
 #   http://stein.cshl.org/WWW/software/CGI/
 
-$CGI::revision = '$Id: CGI.pm,v 1.193 2005/12/05 13:52:24 lstein Exp $';
-$CGI::VERSION='3.13_01';
+$CGI::revision = '$Id: CGI.pm,v 1.194 2005/12/06 22:12:56 lstein Exp $';
+$CGI::VERSION='3.14_01';
 
 # HARD-CODED LOCATION FOR FILE UPLOAD TEMPORARY FILES.
 # UNCOMMENT THIS ONLY IF YOU KNOW WHAT YOU'RE DOING.
@@ -2509,7 +2509,7 @@ sub scrolling_list {
 	$label=$self->escapeHTML($label);
 	my($value)=$self->escapeHTML($_,1);
         my $attribs = $self->_set_attributes($_, $attributes);
-        $result .= "<option$selectit$attribs value=\"$value\">$label</option>\n";
+        $result .= "<option ${selectit}${attribs}value=\"$value\">$label</option>\n";
     }
     $result .= "</select>";
     $self->register_parameter($name);
diff --git a/lib/CGI/Changes b/lib/CGI/Changes
index b4b4619..8c0c42c 100644
--- a/lib/CGI/Changes
+++ b/lib/CGI/Changes
@@ -1,3 +1,6 @@
+  Version 3.14 Tue Dec  6 17:12:03 EST 2005
+   1. Fixed broken scrolling_list() select attribute.
+	
   Version 3.13
     1. Removed extraneous empty "?" from end of self_url().
 
diff --git a/lib/CGI/t/form.t b/lib/CGI/t/form.t
index 558dce9..54b3792 100755
--- a/lib/CGI/t/form.t
+++ b/lib/CGI/t/form.t
@@ -4,7 +4,7 @@
 # ensure the blib's are in @INC, else we might use the core CGI.pm
 use lib qw(. ./blib/lib ./blib/arch);
 
-use Test::More tests => 17;
+use Test::More tests => 18;
 
 BEGIN { use_ok('CGI'); };
 use CGI (':standard','-no_debug','-tabindex');
@@ -117,3 +117,13 @@ is(popup_menu(-name     => 'game',
 <option selected="selected" value="cribbage">cribbage</option>
 </select>',
    'popup_menu()');
+is(scrolling_list(-name => 'game',
+		  '-values' => [qw/checkers chess cribbage/],
+		  -default => 'cribbage',
+		  -override=>1),
+   '<select name="game" tabindex="22"  size="3">
+<option value="checkers">checkers</option>
+<option value="chess">chess</option>
+<option selected="selected" value="cribbage">cribbage</option>
+</select>',
+  'scrolling_list()');