From: Matt S Trout Date: Tue, 24 Jan 2006 18:19:24 +0000 (+0000) Subject: Disabled pod test, tweaked storage_type behaviour, couple code fixups X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=1e10a11d9a973db300c5d94b914bc270c0fa6fb8;p=dbsrgits%2FDBIx-Class-Historic.git Disabled pod test, tweaked storage_type behaviour, couple code fixups --- diff --git a/MANIFEST b/MANIFEST index 38d551c..c26ea8a 100644 --- a/MANIFEST +++ b/MANIFEST @@ -36,6 +36,7 @@ lib/DBIx/Class/Manual.pod lib/DBIx/Class/Manual/Cookbook.pod lib/DBIx/Class/Manual/FAQ.pod lib/DBIx/Class/Manual/Intro.pod +lib/DBIx/Class/Manual/SchemaIntro.pod lib/DBIx/Class/Manual/Troubleshooting.pod lib/DBIx/Class/ObjectCache.pm lib/DBIx/Class/PK.pm @@ -57,25 +58,25 @@ lib/DBIx/Class/Relationship/Helpers.pm lib/DBIx/Class/Relationship/ManyToMany.pm lib/DBIx/Class/Relationship/ProxyMethods.pm lib/DBIx/Class/ResultSet.pm -lib/DBIx/Class/ResultSetInstance.pm +lib/DBIx/Class/ResultSetProxy.pm lib/DBIx/Class/ResultSource.pm lib/DBIx/Class/ResultSource/Table.pm -lib/DBIx/Class/ResultSourceInstance.pm +lib/DBIx/Class/ResultSourceProxy.pm +lib/DBIx/Class/ResultSourceProxy/Table.pm lib/DBIx/Class/Row.pm lib/DBIx/Class/Schema.pm lib/DBIx/Class/Storage/DBI.pm lib/DBIx/Class/Storage/DBI/Cursor.pm -lib/DBIx/Class/TableInstance.pm lib/DBIx/Class/Test/SQLite.pm lib/DBIx/Class/UUIDColumns.pm lib/DBIx/Class/Validation.pm lib/SQL/Translator/Parser/DBIx/Class.pm +lib/SQL/Translator/Producer/DBIx/Class/File.pm Makefile.PL MANIFEST This list of files -META.yml README t/02pod.t -t/03podcoverage.t +t/03podcoverage.t.disabled t/04dont_break_c3.t t/18inserterror.t t/19quotes.t @@ -134,6 +135,7 @@ t/helperrels/16joins.t t/helperrels/17join_count.t t/helperrels/18self_referencial.t t/helperrels/19uuid.t +t/helperrels/20unique.t t/lib/DBICTest.pm t/lib/DBICTest/BasicRels.pm t/lib/DBICTest/HelperRels.pm @@ -172,6 +174,7 @@ t/run/16joins.tl t/run/17join_count.tl t/run/18self_referencial.tl t/run/19uuid.tl +t/run/20unique.tl t/testlib/Actor.pm t/testlib/ActorAlias.pm t/testlib/Binary.pm @@ -190,3 +193,4 @@ t/testlib/MyStarLinkMCPK.pm t/testlib/Order.pm t/testlib/OtherFilm.pm t/testlib/PgBase.pm +META.yml diff --git a/lib/DBIx/Class/ResultSource/Table.pm b/lib/DBIx/Class/ResultSource/Table.pm index 4837e79..41b5432 100644 --- a/lib/DBIx/Class/ResultSource/Table.pm +++ b/lib/DBIx/Class/ResultSource/Table.pm @@ -8,10 +8,7 @@ use DBIx::Class::ResultSet; use Carp qw/croak/; use base qw/DBIx::Class/; -__PACKAGE__->load_components(qw/ResultSource AccessorGroup/); - -__PACKAGE__->mk_group_accessors('simple' => - qw/_columns _primaries name resultset_class result_class schema/); +__PACKAGE__->load_components(qw/ResultSource/); =head1 NAME diff --git a/lib/DBIx/Class/Schema.pm b/lib/DBIx/Class/Schema.pm index ad13b94..afa7e0b 100644 --- a/lib/DBIx/Class/Schema.pm +++ b/lib/DBIx/Class/Schema.pm @@ -11,7 +11,7 @@ use base qw/DBIx::Class/; __PACKAGE__->load_components(qw/Exception/); __PACKAGE__->mk_classdata('class_mappings' => {}); __PACKAGE__->mk_classdata('source_registrations' => {}); -__PACKAGE__->mk_classdata('storage_type' => 'DBI'); +__PACKAGE__->mk_classdata('storage_type' => '::DBI'); __PACKAGE__->mk_classdata('storage'); =head1 NAME @@ -294,7 +294,9 @@ the schema. sub connection { my ($self, @info) = @_; - my $storage_class = 'DBIx::Class::Storage::'.$self->storage_type; + my $storage_class = $self->storage_type; + $storage_class = 'DBIx::Class::Storage'.$storage_class + if $storage_class =~ m/^::/; $storage_class->require; my $storage = $storage_class->new; $storage->connect_info(\@info); diff --git a/t/03podcoverage.t b/t/03podcoverage.t.disabled similarity index 100% rename from t/03podcoverage.t rename to t/03podcoverage.t.disabled