From: Rafael Kitover Date: Fri, 21 Jan 2011 12:24:31 +0000 (-0500) Subject: improve MSSQL+ODBC initialization, clarify docs on SCOPE_IDENTITY() and dynamic cursors X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=1db83fb9;p=dbsrgits%2FDBIx-Class-Historic.git improve MSSQL+ODBC initialization, clarify docs on SCOPE_IDENTITY() and dynamic cursors --- diff --git a/lib/DBIx/Class/Storage/DBI/ODBC/Microsoft_SQL_Server.pm b/lib/DBIx/Class/Storage/DBI/ODBC/Microsoft_SQL_Server.pm index eef33fe..33b53e3 100644 --- a/lib/DBIx/Class/Storage/DBI/ODBC/Microsoft_SQL_Server.pm +++ b/lib/DBIx/Class/Storage/DBI/ODBC/Microsoft_SQL_Server.pm @@ -79,11 +79,11 @@ In order of preference, they are: =over 8 -=item * L +=item * L -=item * L +=item * L -=item * L +=item * L =back @@ -95,6 +95,15 @@ Use as: on_connect_call => 'use_mars' +in your connection info, or alternatively specify it directly: + + Your::Schema->connect ( + $original_dsn . '; MARS_Connection=Yes', + $user, + $pass, + \%attrs, + ) + Use to enable a feature of SQL Server 2005 and later, "Multiple Active Result Sets". See L for more information. @@ -149,84 +158,86 @@ Use as: on_connect_call => 'use_dynamic_cursors' -in your L as one way to enable multiple -concurrent statements. +Which will add C<< odbc_cursortype => 2 >> to your DBI connection +attributes, or alternatively specify the necessary flag directly: -Will add C<< odbc_cursortype => 2 >> to your DBI connection attributes. See -L for more information. + Your::Schema->connect (@dsn, { ... odbc_cursortype => 2 }) -Alternatively, you can add it yourself and dynamic cursor support will be -automatically enabled. +See L for more information. If you're using FreeTDS, C must be set to at least C<8.0>. This will not work with CODE ref connect_info's. -B this will break C, and C will be used instead, which on SQL +Server 2005 and later will return erroneous results on tables which have an on +insert trigger that inserts into another table with an C column. =cut sub connect_call_use_dynamic_cursors { my $self = shift; - if (ref($self->_dbi_connect_info->[0]) eq 'CODE') { - $self->throw_exception ('Cannot set DBI attributes on a CODE ref connect_info'); - } - - my $dbi_attrs = $self->_dbi_connect_info->[-1]; + my $conn_info = $self->_dbi_connect_info; - unless (ref $dbi_attrs eq 'HASH') { - $dbi_attrs = {}; - push @{ $self->_dbi_connect_info }, $dbi_attrs; + if (ref($conn_info->[0]) eq 'CODE') { + $self->throw_exception ('Cannot set DBI attributes on a CODE ref connect_info'); } - if (not exists $dbi_attrs->{odbc_cursortype}) { - # turn on support for multiple concurrent statements, unless overridden - $dbi_attrs->{odbc_cursortype} = 2; + if ( + ref($conn_info->[-1]) ne 'HASH' + or + ($conn_info->[-1]{odbc_cursortype}||0) < 2 + ) { + # reenter connection information with the attribute re-set + $self->connect_info( + @{$conn_info}[0,1,2], + { %{$self->_dbix_connect_attributes}, odbc_cursortype => 2 }, + ); $self->disconnect; # resetting dbi attrs, so have to reconnect $self->ensure_connected; - $self->_set_dynamic_cursors; } } -sub _set_dynamic_cursors { - my $self = shift; - my $dbh = $self->_get_dbh; - - try { - local $dbh->{RaiseError} = 1; - local $dbh->{PrintError} = 0; - $dbh->do('SELECT @@IDENTITY'); - } catch { - $self->throw_exception (<<'EOF'); - -Your drivers do not seem to support dynamic cursors (odbc_cursortype => 2), -if you're using FreeTDS, make sure to set tds_version to 8.0 or greater. -EOF - }; - - $self->_using_dynamic_cursors(1); - $self->_identity_method('@@identity'); -} - -sub _init { +sub _run_connection_actions { my $self = shift; + # keep the dynamic_cursors_support and driver-state in sync + # on every reconnect + my $use_dyncursors = ($self->_dbic_connect_attributes->{odbc_cursortype} || 0) > 1; if ( - ref($self->_dbi_connect_info->[0]) ne 'CODE' - && - ref ($self->_dbi_connect_info->[-1]) eq 'HASH' - && - ($self->_dbi_connect_info->[-1]{odbc_cursortype} || 0) > 1 + $use_dyncursors + xor + !!$self->_using_dynamic_cursors ) { - $self->_set_dynamic_cursors; - } - else { - $self->_using_dynamic_cursors(0); + if ($use_dyncursors) { + try { + my $dbh = $self->_dbh; + local $dbh->{RaiseError} = 1; + local $dbh->{PrintError} = 0; + $dbh->do('SELECT @@IDENTITY'); + } catch { + $self->throw_exception ( + 'Your drivers do not seem to support dynamic cursors (odbc_cursortype => 2).' + . ( + $self->using_freetds + ? ' If you are using FreeTDS, make sure to set tds_version to 8.0 or greater.' + : '' + ) + ); + }; + + $self->_using_dynamic_cursors(1); + $self->_identity_method('@@identity'); + } + else { + $self->_using_dynamic_cursors(0); + $self->_identity_method(undef); + } } + + $self->next::method (@_); } =head2 connect_call_use_server_cursors