From: André Walker Date: Sat, 30 Jul 2011 03:27:14 +0000 (-0300) Subject: service is in subcontainer, not root container. put a fixme in the test that help... X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=1b5451ef09edf0638b6932d697f43b5dd8ede6d8;p=catagits%2FCatalyst-Runtime.git service is in subcontainer, not root container. put a fixme in the test that help me find it, but had nothing to do with it --- diff --git a/lib/Catalyst/IOC/Container.pm b/lib/Catalyst/IOC/Container.pm index c646d84..fc41098 100644 --- a/lib/Catalyst/IOC/Container.pm +++ b/lib/Catalyst/IOC/Container.pm @@ -600,7 +600,7 @@ sub get_components_names_types { for my $sub_container_name (qw/model view controller/) { my $sub_container = $self->get_sub_container($sub_container_name); for my $service ( $sub_container->get_service_list ) { - my $comp = $self->resolve(service => $service); + my $comp = $sub_container->resolve(service => $service); my $compname = ref $comp || $comp; my $type = ref $comp ? 'instance' : 'class'; push @comps_names_types, [ $compname, $type ]; diff --git a/t/live_show_internal_actions_warnings.t b/t/live_show_internal_actions_warnings.t index 0fe6ea3..f0cd2c4 100644 --- a/t/live_show_internal_actions_warnings.t +++ b/t/live_show_internal_actions_warnings.t @@ -20,6 +20,10 @@ my $last_warning; local $SIG{__WARN__} = sub { $last_warning = shift }; my $res = get('/'); } + +# FIXME - is this test really useful? +# it doesn't change anything if we remove the show_internal_actions => 1 line +# from TestAppShowInternalActions is( $last_warning, undef, 'there should be no warnings about uninitialized value' ); done_testing;