From: Graham Knop <haarg@haarg.org>
Date: Tue, 1 Apr 2014 14:29:31 +0000 (-0400)
Subject: comments about why we have some exceptions to fatal
X-Git-Tag: v1.999_001~1^2~12
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=1931c77d270438923f75b6e2ff4913a89fc9e83e;p=p5sagit%2Fstrictures.git

comments about why we have some exceptions to fatal
---

diff --git a/lib/strictures.pm b/lib/strictures.pm
index 43a6600..f618f66 100644
--- a/lib/strictures.pm
+++ b/lib/strictures.pm
@@ -125,18 +125,18 @@ sub _enable_1 {
   }
 }
 
-our @V2_NONFATAL = grep { exists $warnings::Offsets{$_} } qw(
-  exec
-  recursion
-  internal
-  malloc
-  newline
-  experimental
-  deprecated
-  portable
+our @V2_NONFATAL = grep { exists $warnings::Offsets{$_} } (
+  'exec',         # not safe to catch
+  'recursion',    # will be caught by other mechanisms
+  'internal',     # not safe to catch
+  'malloc',       # not safe to catch
+  'newline',      # stat on nonexistent file with a newline in it
+  'experimental', # no reason for these to be fatal
+  'deprecated',   # unfortunately can't make these fatal
+  'portable',     # everything worked fine here, just may not elsewhere
 );
-our @V2_DISABLE = grep { exists $warnings::Offsets{$_} } qw(
-  once
+our @V2_DISABLE = grep { exists $warnings::Offsets{$_} } (
+  'once'          # triggers inconsistently, can't be fatalized
 );
 
 sub _enable_2 {