From: Jim Cromie Date: Mon, 25 Oct 2004 16:36:40 +0000 (-0600) Subject: [patches] optree_* tests unexpectedly succeeding. + maint-only patch X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=181f6ff5f88de6db5f8bade64a581afc9c32fcfc;p=p5sagit%2Fp5-mst-13.2.git [patches] optree_* tests unexpectedly succeeding. + maint-only patch Message-ID: Date: Mon, 25 Oct 2004 16:36:40 -0600 p4raw-id: //depot/perl@23446 --- diff --git a/ext/B/t/optree_check.t b/ext/B/t/optree_check.t index 6150cce..a037a78 100644 --- a/ext/B/t/optree_check.t +++ b/ext/B/t/optree_check.t @@ -60,6 +60,10 @@ checkOptree ( name => 'test skip itself', expect => 'dont-care, skipping', expect_nt => 'this insures failure'); +# This test 'unexpectedly succeeds', but that is "expected". Theres +# no good way to expect a successful todo, and inducing a failure +# causes the harness to print verbose errors, which is NOT helpful. + checkOptree ( name => 'test todo itself', todo => "your excuse here ;-)", bcopts => '-exec', @@ -159,11 +163,10 @@ EOT_EOT # 3 <1> leavesub[1 ref] K/REFC,1 EONT_EONT -checkOptree ( name => 'fixup square-bracket args', +checkOptree ( name => 'fixup opcode args', bcopts => '-exec', - todo => 'not done in rexpedant mode', + #fail => 1, # uncomment to see real padsv args: [$a:491,492] code => sub {my $a}, - #skip => 1, expect => <<'EOT_EOT', expect_nt => <<'EONT_EONT'); # 1 <;> nextstate(main 56 optree_concise.t:96) v # 2 <0> padsv[$a:56,57] M/LVINTRO diff --git a/ext/B/t/optree_varinit.t b/ext/B/t/optree_varinit.t index 824bcb0..e7fd492 100644 --- a/ext/B/t/optree_varinit.t +++ b/ext/B/t/optree_varinit.t @@ -246,7 +246,6 @@ EONT_EONT checkOptree ( name => 'sub {my $a=()}', code => sub {my $a=()}, - todo => 'apparently done, by patch #?', bcopts => '-exec', expect => <<'EOT_EOT', expect_nt => <<'EONT_EONT'); 1 <;> nextstate(main -439 optree.t:105) v @@ -300,7 +299,6 @@ EONT_EONT checkOptree ( name => 'my $a=()', prog => 'my $a=()', - todo => 'apparently done, by patch #?', bcopts => '-exec', expect => <<'EOT_EOT', expect_nt => <<'EONT_EONT'); 1 <0> enter