From: Peter Rabbitson Date: Wed, 20 May 2015 19:02:47 +0000 (+0200) Subject: Fix forgotten 'unless' tripped by 05a5ca4b (introduced in c863e102) X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=17f1b61e35f4e37bac433a16d88124dc06868895;p=dbsrgits%2FDBIx-Class.git Fix forgotten 'unless' tripped by 05a5ca4b (introduced in c863e102) Why was this never detected? Because the deparse differs *only* on 5.10.[01] IFF compiled without -DDebugging. I hate everything --- diff --git a/t/resultset/rowparser_internals.t b/t/resultset/rowparser_internals.t index 5818248..9d38e90 100644 --- a/t/resultset/rowparser_internals.t +++ b/t/resultset/rowparser_internals.t @@ -871,9 +871,10 @@ is_same_src ( ( $collapse_idx[0]{$cur_row_ids{3}} //= $_[0][$result_pos++] = [] ), ( ( ! defined $cur_row_data->[0] ) ? $collapse_idx[0]{$cur_row_ids{3}}[1]{"books"} = [] : do { + ( ! $collapse_idx[1]{$cur_row_ids{0}} ) + and push @{$collapse_idx[0]{$cur_row_ids{3}}[1]{books}}, $collapse_idx[1]{$cur_row_ids{0}} = [ { owner => $cur_row_data->[1], title => $cur_row_data->[0] } ] - unless $collapse_idx[1]{$cur_row_ids{0}} } ), }