From: Nicholas Clark <nick@ccl4.org>
Date: Thu, 18 Mar 2004 16:58:06 +0000 (+0000)
Subject: Corrections and explanations in comments
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=17625bd2bf8805259796589d280425017e98f645;p=p5sagit%2Fp5-mst-13.2.git

Corrections and explanations in comments

p4raw-id: //depot/perl@22528
---

diff --git a/ext/Storable/Storable.xs b/ext/Storable/Storable.xs
index 2d44097..7f47983 100644
--- a/ext/Storable/Storable.xs
+++ b/ext/Storable/Storable.xs
@@ -2455,7 +2455,7 @@ static int store_code(stcxt_t *cxt, CV *cv)
 	 * Require B::Deparse. At least B::Deparse 0.61 is needed for
 	 * blessed code references.
 	 */
-	/* XXX sv_2mortal seems to be evil here. why? */
+	/* Ownership of both SVs is passed to load_module, which frees them. */
 	load_module(PERL_LOADMOD_NOIMPORT, newSVpvn("B::Deparse",10), newSVnv(0.61));
 
 	ENTER;
@@ -3315,7 +3315,7 @@ static int store(stcxt_t *cxt, SV *sv)
 			*/
 			/* Need to jump past the next hv_store, because on the
 			   second store of undef the old hash value will be
-			   SV_REFCNT_DEC()ed, and as Storable cheats horribly
+			   SvREFCNT_dec()ed, and as Storable cheats horribly
 			   by storing non-SVs in the hash a SEGV will ensure.
 			   Need to increase the tag number so that the
 			   receiver has no idea what games we're up to.  This