From: Peter Rabbitson <ribasushi@cpan.org>
Date: Mon, 3 Aug 2009 13:16:10 +0000 (+0000)
Subject: Simplify code and add some comments
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=1537084d8b9f01aa99e0a4bd6ef306758e0eb123;hp=8bc3fbf554405dd6e1f3b1cf6c6f251dcbf4ea00;p=dbsrgits%2FDBIx-Class-Historic.git

Simplify code and add some comments
---

diff --git a/lib/DBIx/Class/Storage/DBI/MSSQL.pm b/lib/DBIx/Class/Storage/DBI/MSSQL.pm
index d322d46..9d88ed0 100644
--- a/lib/DBIx/Class/Storage/DBI/MSSQL.pm
+++ b/lib/DBIx/Class/Storage/DBI/MSSQL.pm
@@ -84,10 +84,10 @@ sub _prep_for_execute {
 # cast MONEY values properly
   if ($op eq 'insert' || $op eq 'update') {
     my $fields = $args->[0];
-    my $col_info = $self->_resolve_column_info($ident, [keys %$fields]);
 
     for my $col (keys %$fields) {
-      if ($col_info->{$col}{data_type} =~ /^money\z/i) {
+      # $ident is a result source object with INSERT/UPDATE ops
+      if ($ident->column_info ($col)->{data_type} =~ /^money\z/i) {
         my $val = $fields->{$col};
         $fields->{$col} = \['CAST(? AS MONEY)', [ $col => $val ]];
       }
@@ -117,25 +117,25 @@ sub _execute {
   my ($op) = @_;
 
   my ($rv, $sth, @bind) = $self->dbh_do($self->can('_dbh_execute'), @_);
+
   if ($op eq 'insert') {
-    $self->_identity($self->_fetch_identity($sth));
-  }
 
-  return wantarray ? ($rv, $sth, @bind) : $rv;
-}
+    # this should bring back the result of SELECT SCOPE_IDENTITY() we tacked
+    # on in _prep_for_execute above
+    my ($identity) = $sth->fetchrow_array;
 
-sub _fetch_identity {
-  my ($self, $sth) = @_;
-  my ($identity) = $sth->fetchrow_array;
-  $sth->finish;
+    # SCOPE_IDENTITY failed, but we can do something else
+    if ( (! $identity) && $self->_identity_method) {
+      ($identity) = $self->_dbh->selectrow_array(
+        'select ' . $self->_identity_method
+      );
+    }
 
-  if ((not defined $identity) && $self->_identity_method) {
-    ($identity) = $self->_dbh->selectrow_array(
-      'select ' . $self->_identity_method
-    );
+    $self->_identity($identity);
+    $sth->finish;
   }
 
-  return $identity;
+  return wantarray ? ($rv, $sth, @bind) : $rv;
 }
 
 sub last_insert_id { shift->_identity }