From: Peter Rabbitson <ribasushi@cpan.org>
Date: Thu, 28 May 2009 08:20:57 +0000 (+0000)
Subject: Commit rather useless but already written mysql test extension
X-Git-Tag: v0.08106~53
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=13a2f0311c4d16131b69bea50edb3805958a62a9;p=dbsrgits%2FDBIx-Class.git

Commit rather useless but already written mysql test extension
---

diff --git a/t/71mysql.t b/t/71mysql.t
index cb21aa7..cf02a61 100644
--- a/t/71mysql.t
+++ b/t/71mysql.t
@@ -14,7 +14,7 @@ my ($dsn, $user, $pass) = @ENV{map { "DBICTEST_MYSQL_${_}" } qw/DSN USER PASS/};
 plan skip_all => 'Set $ENV{DBICTEST_MYSQL_DSN}, _USER and _PASS to run this test'
   unless ($dsn && $user);
 
-plan tests => 15;
+plan tests => 23;
 
 my $schema = DBICTest::Schema->connect($dsn, $user, $pass);
 
@@ -104,22 +104,61 @@ $schema->populate ('Owners', [
 
 $schema->populate ('BooksInLibrary', [
   [qw/source  owner title   /],
-  [qw/nsa     1     secrets1/],
-  [qw/fbi     1     secrets2/],
-  [qw/cia     2     secrets3/],
+  [qw/Library 1     secrets1/],
+  [qw/Eatery  1     secrets2/],
+  [qw/Library 2     secrets3/],
 ]);
 
-# try a distinct + prefetch with tables with identical columns (mysql allegedly doesn't like this)
-my $owners = $schema->resultset ('Owners')->search (
-  { 'books.id' => { '!=', undef }},
-  { prefetch => 'books', distinct => 1 }
-);
-my $owners2 = $schema->resultset ('Owners')->search ({ id => { -in => $owners->get_column ('me.id')->as_query }});
-for ($owners, $owners2) {
-  is ($_->all, 2, 'Prefetched grouped search returns correct number of rows');
-  is ($_->count, 2, 'Prefetched grouped search returns correct count');
-}
+#
+# try a distinct + prefetch on tables with identically named columns 
+# (mysql doesn't seem to like subqueries with equally named columns)
+#
 
+SKIP: {
+  # try a ->has_many direction (due to a 'multi' accessor the select/group_by group is collapsed)
+  my $owners = $schema->resultset ('Owners')->search (
+    { 'books.id' => { '!=', undef }},
+    { prefetch => 'books', distinct => 1 }
+  );
+  my $owners2 = $schema->resultset ('Owners')->search ({ id => { -in => $owners->get_column ('me.id')->as_query }});
+  for ($owners, $owners2) {
+    lives_ok { is ($_->all, 2, 'Prefetched grouped search returns correct number of rows') }
+      || skip ('No test due to exception', 1);
+    lives_ok { is ($_->count, 2, 'Prefetched grouped search returns correct count') }
+      || skip ('No test due to exception', 1);
+  }
+
+  TODO: {
+    # try a ->prefetch direction (no select collapse)
+    my $books = $schema->resultset ('BooksInLibrary')->search (
+      { 'owner.name' => 'wiggle' },
+      { prefetch => 'owner', distinct => 1 }
+    );
+
+    local $TODO = 'MySQL is crazy - there seems to be no way to make this work';
+    # error thrown is:
+    # Duplicate column name 'id' [for Statement "
+    #   SELECT COUNT( * )
+    #     FROM (
+    #       SELECT me.id, me.source, me.owner, me.title, me.price, owner.id, owner.name
+    #         FROM books me
+    #         JOIN owners owner ON owner.id = me.owner 
+    #       WHERE ( ( owner.name = ? AND source = ? ) ) 
+    #       GROUP BY me.id, me.source, me.owner, me.title, me.price, owner.id, owner.name
+    #     ) count_subq
+    # " with ParamValues: 0='wiggle', 1='Library']
+    #
+    # go fucking figure
+
+    my $books2 = $schema->resultset ('BooksInLibrary')->search ({ id => { -in => $books->get_column ('me.id')->as_query }});
+    for ($books, $books2) {
+      lives_ok { is ($_->all, 1, 'Prefetched grouped search returns correct number of rows') }
+        || skip ('No test due to exception', 1);
+      lives_ok { is ($_->count, 1, 'Prefetched grouped search returns correct count') }
+        || skip ('No test due to exception', 1);
+    }
+  }
+}
 
 SKIP: {
     my $mysql_version = $dbh->get_info( $GetInfoType{SQL_DBMS_VER} );
diff --git a/t/lib/DBICTest/Schema/BooksInLibrary.pm b/t/lib/DBICTest/Schema/BooksInLibrary.pm
index b239253..8da54e6 100644
--- a/t/lib/DBICTest/Schema/BooksInLibrary.pm
+++ b/t/lib/DBICTest/Schema/BooksInLibrary.pm
@@ -29,4 +29,6 @@ __PACKAGE__->set_primary_key('id');
 
 __PACKAGE__->resultset_attributes({where => { source => "Library" } });
 
+__PACKAGE__->belongs_to ( owner => 'DBICTest::Schema::Owners', 'owner' );
+
 1;
diff --git a/t/lib/sqlite.sql b/t/lib/sqlite.sql
index 4bcb485..441c811 100644
--- a/t/lib/sqlite.sql
+++ b/t/lib/sqlite.sql
@@ -1,6 +1,6 @@
 -- 
 -- Created by SQL::Translator::Producer::SQLite
--- Created on Tue May 26 18:29:15 2009
+-- Created on Thu May 28 10:10:00 2009
 -- 
 
 
@@ -82,6 +82,8 @@ CREATE TABLE books (
   price integer
 );
 
+CREATE INDEX books_idx_owner_books ON books (owner);
+
 --
 -- Table: cd
 --