From: Nicholas Clark <nick@ccl4.org>
Date: Thu, 26 Mar 2015 20:14:42 +0000 (+0100)
Subject: Avoid tests failing because Test::More changes the size of %::
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=13a207d7244cf5835f1952ebc90d2bd5ce665abd;p=p5sagit%2FDevel-Size.git

Avoid tests failing because Test::More changes the size of %::
---

diff --git a/CHANGES b/CHANGES
index cb90fb9..63989e9 100644
--- a/CHANGES
+++ b/CHANGES
@@ -2,6 +2,7 @@ Revision history for Perl extension Devel::Size.
 
 0.79_54 2015-03-27 nicholas
   * Fix the definition of padlist_size() for post-5.20 perls.
+  * Avoid tests failing because Test::More lazy-loading changes the size of %::
 
 0.79_53 2015-03-25 nicholas
   * Avoid t/recurse.t failing on earlier versions on 32 bit platforms
diff --git a/t/code.t b/t/code.t
index f57a3fe..0cf3a4d 100644
--- a/t/code.t
+++ b/t/code.t
@@ -4,6 +4,27 @@ use strict;
 use Test::More tests => 18;
 use Devel::Size ':all';
 
+# For me, for some files locally, I'm seeing failures
+# Failed test '&two_lex is bigger than an empty sub by less than 2048 bytes'
+# Just for some perl versions (5.8.7, 5.10.1, some 5.12.*)
+# As ever, the reason is subtle and annoying. As this test is running in package
+# main, loading modules at runtime might create entries in %::
+# In this case, it's just one key, '_</.../lib/perl5/5.12.4/overload.pm'
+# because Test::More is demand loading overload at the first test.
+# So the first fix I tried was to "encourage" Test::More to get all this done
+# before we start doing things that are sensitive to the size of %::
+# with this:
+#
+# cmp_ok(1, '==', 1, "prompt Test::More to load everything it needs *now*");
+#
+# which fixed most things, but not 5.8.7, which (*only under make test*) would
+# fail '&two_lex is bigger than an empty sub by less than 2048 bytes'
+# Turns out that Test::More 0.54 creates an entry in %:: for every test run
+# (not sure why, side effect of an eval with a #line directive, maybe?)
+# The solution is to measure (and re-measure) the size of things you're
+# comparing as contiguous statements, assigning to variables, and then make
+# calls to Test::More functions.
+
 sub zwapp;
 sub swoosh($$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$);
 sub crunch {
@@ -102,6 +123,8 @@ sub ode {
     # Sadly all but one of the remaining versus are too long for an identifier.
 }
 
+# Aargh, re-measure it. See comment at the top of the file.
+$crunch_size = total_size(\&crunch);
 my $two_lex_size = total_size(\&two_lex);
 cmp_ok($two_lex_size, '>', $crunch_size,
        '&two_lex is bigger than an empty sub');