From: Craig A. Berry Date: Fri, 16 Nov 2007 23:46:13 +0000 (+0000) Subject: The new Archive::Tar tests are TODO on VMS for reasons unrelated X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=130fdcc93ad3c25c64febb23ca35708cbb56d231;p=p5sagit%2Fp5-mst-13.2.git The new Archive::Tar tests are TODO on VMS for reasons unrelated to the security issue for which they are testing. p4raw-id: //depot/perl@32352 --- diff --git a/lib/Archive/Tar/t/04_resolved_issues.t b/lib/Archive/Tar/t/04_resolved_issues.t index ecaa150..8d17923 100644 --- a/lib/Archive/Tar/t/04_resolved_issues.t +++ b/lib/Archive/Tar/t/04_resolved_issues.t @@ -121,6 +121,7 @@ use_ok( $FileClass ); " Renamed to '$out_file'" ); ### first, test with strict extract permissions on +TODO: { local $Archive::Tar::INSECURE_EXTRACT_MODE = 0; ### we quell the error on STDERR @@ -134,14 +135,20 @@ use_ok( $FileClass ); ok( ! -e $out_file, " File '$out_file' does not exist" ); ok( $tar->error, " Error message stored" ); + + local $TODO = 'Exposed unrelated filespec handling bugs on VMS' if $^O eq 'VMS'; + like( $tar->error, qr/attempting to leave/, " Proper violation detected" ); } ### now disable those +TODO: { local $Archive::Tar::INSECURE_EXTRACT_MODE = 1; ok( 1, " Extracting in insecure mode" ); + local $TODO = 'Exposed unrelated filespec handling bugs on VMS' if $^O eq 'VMS'; + ok( $tar->extract_file( $out_file ), " File extracted" ); ok( -e $out_file, " File '$out_file' exists" );