From: Peter Rabbitson Date: Sat, 12 Jun 2010 00:44:20 +0000 (+0200) Subject: A guard to make sure we don't ship with a ton of deps ever again X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=1278e5f0200f8cd8bd4cf137ae7ed571f71e63c2;p=dbsrgits%2FDBIx-Class-Historic.git A guard to make sure we don't ship with a ton of deps ever again --- diff --git a/Makefile.PL b/Makefile.PL index 5b493d2..ab98a45 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -228,18 +228,39 @@ no_index package => $_ for (qw/ WriteAll(); - # Re-write META.yml to _exclude_ all forced requires (we do not want to ship this) +# We are also not using M::I::AuthorRequires as this will be an extra dep, and +# deps in Makefile.PL suck (no autoinstall) if ($Module::Install::AUTHOR && ! $args->{skip_author_deps} ) { # FIXME test_requires is not yet part of META my %original_build_requires = ( %$build_requires, %$test_requires ); + my @all_build_requires = @{delete Meta->{values}{build_requires}}; + my %removed_build_requires; - print "Regenerating META with author requires excluded\n"; - Meta->{values}{build_requires} = [ grep - { exists $original_build_requires{$_->[0]} } - ( @{Meta->{values}{build_requires}} ) - ]; + for (@all_build_requires) { + if ($original_build_requires{$_->[0]}) { + push @{Meta->{values}{build_requires}}, $_; + } + else { + $removed_build_requires{$_->[0]} = $_->[1] + unless $_->[0] eq 'ExtUtils::MakeMaker'; + } + } + print "Regenerating META with author requires excluded\n"; Meta->write; + + # test that we really took things away (just in case) + my $meta = do { local @ARGV = 'META.yml'; local $/; <> }; + for (keys %removed_build_requires) { + delete $removed_build_requires{$_} + unless $meta =~ /^ \s+ $_: \s+ $removed_build_requires{$_} \s* $/mx + } + + if (keys %removed_build_requires) { + die join ("\n", "\n\nFATAL FAIL! It looks like some author dependencies made it to the META.yml:\n", + map { "\t$_" } (keys %removed_build_requires) + ) . "\n\n"; + } }