From: Jesse Luehrs Date: Thu, 29 Mar 2012 06:37:54 +0000 (-0500) Subject: give the actual reason for this TODO X-Git-Tag: 2.0500~4 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=11ded6089a528660570e6eed62dd12ff0bcbc609;p=gitmo%2FMoose.git give the actual reason for this TODO --- diff --git a/Changes b/Changes index b63c1a7..35de91a 100644 --- a/Changes +++ b/Changes @@ -34,9 +34,9 @@ for, noteworthy changes. user-defined init_meta methods have been called. Fixes RT #51561. (doy) * Fixed a memory leak. This occurred when creating an anonymous - class. Immutabilizing an anonymous class still leaks memory, as the anon - class will never be destroyed in this case. Based on code and bug report - from Carlos Lima. RT #74650. + class. Immutabilizing an anonymous class still leaks memory due to a bug in + Eval::Closure (which should hopefully be fixed soon). Based on code and bug + report from Carlos Lima. RT #74650. 2.0402 Sat, Feb 04, 2012 diff --git a/t/bugs/memory_leaks.t b/t/bugs/memory_leaks.t index e5d969e..10127f9 100644 --- a/t/bugs/memory_leaks.t +++ b/t/bugs/memory_leaks.t @@ -72,8 +72,10 @@ no_leaks_ok( ); { - local $TODO - = 'Until we eliminate meta objects from being closed over by the immutabilized methods, this will leak'; + # fixing this leak currently triggers a bug in Carp + # we can un-TODO once that fix goes in allowing the leak + # in Eval::Closure to be fixed + local $TODO = 'Eval::Closure leaks a bit at the moment'; no_leaks_ok( sub { my $meta = Moose::Meta::Class->create_anon_class;