From: Peter Rabbitson <ribasushi@cpan.org>
Date: Mon, 30 Jan 2012 11:08:54 +0000 (+0100)
Subject: Move Oracle blob tests into separate file (no functional changes!)
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=1143e5bdc4571a4b6f601940643e611d969e2cfb;p=dbsrgits%2FDBIx-Class-Historic.git

Move Oracle blob tests into separate file (no functional changes!)
---

diff --git a/t/73oracle.t b/t/73oracle.t
index 07f1afa..7028e95 100644
--- a/t/73oracle.t
+++ b/t/73oracle.t
@@ -372,112 +372,6 @@ sub _run_tests {
   is($st->pkid1, 55, "Oracle Auto-PK without trigger: First primary key set manually");
 
 
-# test BLOBs
-  SKIP: {
-  TODO: {
-    my %binstr = ( 'small' => join('', map { chr($_) } ( 1 .. 127 )) );
-    $binstr{'large'} = $binstr{'small'} x 1024;
-
-    my $maxloblen = (length $binstr{'large'}) + 5;
-    note "Localizing LongReadLen to $maxloblen to avoid truncation of test data";
-    local $dbh->{'LongReadLen'} = $maxloblen;
-
-    my $rs = $schema->resultset('BindType');
-
-    if ($DBD::Oracle::VERSION eq '1.23') {
-      throws_ok { $rs->create({ id => 1, blob => $binstr{large} }) }
-        qr/broken/,
-        'throws on blob insert with DBD::Oracle == 1.23';
-
-      skip 'buggy BLOB support in DBD::Oracle 1.23', 1;
-    }
-
-    # disable BLOB mega-output
-    my $orig_debug = $schema->storage->debug;
-
-    local $TODO = 'Something is confusing column bindtype assignment when quotes are active'
-                . ': https://rt.cpan.org/Ticket/Display.html?id=64206'
-      if $q;
-
-    my $id;
-    foreach my $size (qw( small large )) {
-      $id++;
-
-      if ($size eq 'small') {
-        $schema->storage->debug($orig_debug);
-      }
-      elsif ($size eq 'large') {
-        $schema->storage->debug(0);
-      }
-
-      my $str = $binstr{$size};
-      lives_ok {
-        $rs->create( { 'id' => $id, blob => "blob:$str", clob => "clob:$str" } )
-      } "inserted $size without dying";
-
-      my %kids = %{$schema->storage->_dbh->{CachedKids}};
-      my @objs = $rs->search({ blob => "blob:$str", clob => "clob:$str" })->all;
-      is_deeply (
-        $schema->storage->_dbh->{CachedKids},
-        \%kids,
-        'multi-part LOB equality query was not cached',
-      ) if $size eq 'large';
-      is @objs, 1, 'One row found matching on both LOBs';
-      ok (try { $objs[0]->blob }||'' eq "blob:$str", 'blob inserted/retrieved correctly');
-      ok (try { $objs[0]->clob }||'' eq "clob:$str", 'clob inserted/retrieved correctly');
-
-      TODO: {
-        local $TODO = '-like comparison on blobs not tested before ora 10 (fails on 8i)'
-          if $schema->storage->_server_info->{normalized_dbms_version} < 10;
-
-        lives_ok {
-          @objs = $rs->search({ clob => { -like => 'clob:%' } })->all;
-          ok (@objs, 'rows found matching CLOB with a LIKE query');
-        } 'Query with like on blob succeeds';
-      }
-
-      ok(my $subq = $rs->search(
-        { blob => "blob:$str", clob => "clob:$str" },
-        {
-          from => \ "(SELECT * FROM ${q}bindtype_test${q} WHERE ${q}id${q} != ?) ${q}me${q}",
-          bind => [ [ undef => 12345678 ] ],
-        }
-      )->get_column('id')->as_query);
-
-      @objs = $rs->search({ id => { -in => $subq } })->all;
-      is (@objs, 1, 'One row found matching on both LOBs as a subquery');
-
-      lives_ok {
-        $rs->search({ id => $id, blob => "blob:$str", clob => "clob:$str" })
-          ->update({ blob => 'updated blob', clob => 'updated clob' });
-      } 'blob UPDATE with blobs in WHERE clause survived';
-
-      @objs = $rs->search({ blob => "updated blob", clob => 'updated clob' })->all;
-      is @objs, 1, 'found updated row';
-      ok (try { $objs[0]->blob }||'' eq "updated blob", 'blob updated/retrieved correctly');
-      ok (try { $objs[0]->clob }||'' eq "updated clob", 'clob updated/retrieved correctly');
-
-      lives_ok {
-        $rs->search({ id => $id  })
-          ->update({ blob => 're-updated blob', clob => 're-updated clob' });
-      } 'blob UPDATE without blobs in WHERE clause survived';
-
-      @objs = $rs->search({ blob => 're-updated blob', clob => 're-updated clob' })->all;
-      is @objs, 1, 'found updated row';
-      ok (try { $objs[0]->blob }||'' eq 're-updated blob', 'blob updated/retrieved correctly');
-      ok (try { $objs[0]->clob }||'' eq 're-updated clob', 'clob updated/retrieved correctly');
-
-      lives_ok {
-        $rs->search({ blob => "re-updated blob", clob => "re-updated clob" })
-          ->delete;
-      } 'blob DELETE with WHERE clause survived';
-      @objs = $rs->search({ blob => "re-updated blob", clob => 're-updated clob' })->all;
-      is @objs, 0, 'row deleted successfully';
-    }
-
-    $schema->storage->debug ($orig_debug);
-  }}
-
 # test populate (identity, success and error handling)
   my $art_rs = $schema->resultset('Artist');
 
@@ -693,8 +587,6 @@ sub do_creates {
   $dbh->do("CREATE TABLE ${q}track${q} (${q}trackid${q} NUMBER(12), ${q}cd${q} NUMBER(12) REFERENCES CD(${q}cdid${q}) DEFERRABLE, ${q}position${q} NUMBER(12), ${q}title${q} VARCHAR(255), ${q}last_updated_on${q} DATE, ${q}last_updated_at${q} DATE)");
   $dbh->do("ALTER TABLE ${q}track${q} ADD (CONSTRAINT ${q}track_pk${q} PRIMARY KEY (${q}trackid${q}))");
 
-  $dbh->do("CREATE TABLE ${q}bindtype_test${q} (${q}id${q} integer NOT NULL PRIMARY KEY, ${q}bytea${q} integer NULL, ${q}blob${q} blob NULL, ${q}clob${q} clob NULL, ${q}a_memo${q} integer NULL)");
-
   $dbh->do(qq{
     CREATE OR REPLACE TRIGGER ${q}artist_insert_trg_auto${q}
     BEFORE INSERT ON ${q}artist${q}
diff --git a/t/73oracle_blob.t b/t/73oracle_blob.t
new file mode 100644
index 0000000..46d91f1
--- /dev/null
+++ b/t/73oracle_blob.t
@@ -0,0 +1,196 @@
+use strict;
+use warnings;
+
+use Test::Exception;
+use Test::More;
+use Sub::Name;
+use Try::Tiny;
+use DBIx::Class::Optional::Dependencies ();
+
+use lib qw(t/lib);
+use DBICTest;
+use DBIC::SqlMakerTest;
+
+my ($dsn,  $user,  $pass)  = @ENV{map { "DBICTEST_ORA_${_}" }  qw/DSN USER PASS/};
+
+plan skip_all => 'Set $ENV{DBICTEST_ORA_DSN}, _USER and _PASS to run this test.'
+  unless ($dsn && $user && $pass);
+
+plan skip_all => 'Test needs ' . DBIx::Class::Optional::Dependencies->req_missing_for ('test_rdbms_oracle')
+  unless DBIx::Class::Optional::Dependencies->req_ok_for ('test_rdbms_oracle');
+
+$ENV{NLS_SORT} = "BINARY";
+$ENV{NLS_COMP} = "BINARY";
+$ENV{NLS_LANG} = "AMERICAN";
+
+my $v = do {
+  my $v = DBICTest::Schema->connect($dsn, $user, $pass)->storage->_dbh_get_info(18);
+  $v =~ /^(\d+)\.(\d+)/
+    or die "Unparseable Oracle server version: $v\n";
+
+  sprintf('%d.%03d', $1, $2);
+};
+##########
+# the recyclebin (new for 10g) sometimes comes in the way
+my $on_connect_sql = $v >= 10 ? ["ALTER SESSION SET recyclebin = OFF"] : [];
+
+# iterate all tests on following options
+my @tryopt = (
+  { on_connect_do => $on_connect_sql },
+  { quote_char => '"', on_connect_do => $on_connect_sql },
+);
+
+# keep a database handle open for cleanup
+my $dbh;
+
+my $schema;
+for my $opt (@tryopt) {
+  my $schema = DBICTest::Schema->connect($dsn, $user, $pass, $opt);
+
+  $dbh = $schema->storage->dbh;
+  my $q = $schema->storage->sql_maker->quote_char || '';
+
+  do_creates($dbh, $q);
+
+  _run_blob_tests($schema, $opt);
+}
+
+sub _run_blob_tests {
+SKIP: {
+TODO: {
+  my ($schema, $opt) = @_;
+  my %binstr = ( 'small' => join('', map { chr($_) } ( 1 .. 127 )) );
+  $binstr{'large'} = $binstr{'small'} x 1024;
+
+  my $maxloblen = (length $binstr{'large'}) + 5;
+  note "Localizing LongReadLen to $maxloblen to avoid truncation of test data";
+  local $dbh->{'LongReadLen'} = $maxloblen;
+
+  my $rs = $schema->resultset('BindType');
+
+  if ($DBD::Oracle::VERSION eq '1.23') {
+    throws_ok { $rs->create({ id => 1, blob => $binstr{large} }) }
+      qr/broken/,
+      'throws on blob insert with DBD::Oracle == 1.23';
+    skip 'buggy BLOB support in DBD::Oracle 1.23', 1;
+  }
+
+  my $q = $schema->storage->sql_maker->quote_char || '';
+  local $TODO = 'Something is confusing column bindtype assignment when quotes are active'
+              . ': https://rt.cpan.org/Ticket/Display.html?id=64206'
+    if $q;
+
+  # so we can disable BLOB mega-output
+  my $orig_debug = $schema->storage->debug;
+
+  my $id;
+  foreach my $size (qw( small large )) {
+    $id++;
+
+    local $schema->storage->{debug} = $size eq 'large'
+      ? 0
+      : $orig_debug
+    ;
+
+    my $str = $binstr{$size};
+    lives_ok {
+      $rs->create( { 'id' => $id, blob => "blob:$str", clob => "clob:$str" } )
+    } "inserted $size without dying";
+
+    my %kids = %{$schema->storage->_dbh->{CachedKids}};
+    my @objs = $rs->search({ blob => "blob:$str", clob => "clob:$str" })->all;
+    is_deeply (
+      $schema->storage->_dbh->{CachedKids},
+      \%kids,
+      'multi-part LOB equality query was not cached',
+    ) if $size eq 'large';
+    is @objs, 1, 'One row found matching on both LOBs';
+    ok (try { $objs[0]->blob }||'' eq "blob:$str", 'blob inserted/retrieved correctly');
+    ok (try { $objs[0]->clob }||'' eq "clob:$str", 'clob inserted/retrieved correctly');
+
+    TODO: {
+      local $TODO = '-like comparison on blobs not tested before ora 10 (fails on 8i)'
+        if $schema->storage->_server_info->{normalized_dbms_version} < 10;
+
+      lives_ok {
+        @objs = $rs->search({ clob => { -like => 'clob:%' } })->all;
+        ok (@objs, 'rows found matching CLOB with a LIKE query');
+      } 'Query with like on blob succeeds';
+    }
+
+    ok(my $subq = $rs->search(
+      { blob => "blob:$str", clob => "clob:$str" },
+      {
+        from => \ "(SELECT * FROM ${q}bindtype_test${q} WHERE ${q}id${q} != ?) ${q}me${q}",
+        bind => [ [ undef => 12345678 ] ],
+      }
+    )->get_column('id')->as_query);
+
+    @objs = $rs->search({ id => { -in => $subq } })->all;
+    is (@objs, 1, 'One row found matching on both LOBs as a subquery');
+
+    lives_ok {
+      $rs->search({ id => $id, blob => "blob:$str", clob => "clob:$str" })
+        ->update({ blob => 'updated blob', clob => 'updated clob' });
+    } 'blob UPDATE with blobs in WHERE clause survived';
+
+    @objs = $rs->search({ blob => "updated blob", clob => 'updated clob' })->all;
+    is @objs, 1, 'found updated row';
+    ok (try { $objs[0]->blob }||'' eq "updated blob", 'blob updated/retrieved correctly');
+    ok (try { $objs[0]->clob }||'' eq "updated clob", 'clob updated/retrieved correctly');
+
+    lives_ok {
+      $rs->search({ id => $id  })
+        ->update({ blob => 're-updated blob', clob => 're-updated clob' });
+    } 'blob UPDATE without blobs in WHERE clause survived';
+
+    @objs = $rs->search({ blob => 're-updated blob', clob => 're-updated clob' })->all;
+    is @objs, 1, 'found updated row';
+    ok (try { $objs[0]->blob }||'' eq 're-updated blob', 'blob updated/retrieved correctly');
+    ok (try { $objs[0]->clob }||'' eq 're-updated clob', 'clob updated/retrieved correctly');
+
+    lives_ok {
+      $rs->search({ blob => "re-updated blob", clob => "re-updated clob" })
+        ->delete;
+    } 'blob DELETE with WHERE clause survived';
+    @objs = $rs->search({ blob => "re-updated blob", clob => 're-updated clob' })->all;
+    is @objs, 0, 'row deleted successfully';
+  }
+
+  $schema->storage->debug ($orig_debug);
+}}
+
+  do_clean ($dbh);
+}
+
+done_testing;
+
+sub do_creates {
+  my ($dbh, $q) = @_;
+
+  do_clean($dbh);
+
+  $dbh->do("CREATE TABLE ${q}bindtype_test${q} (${q}id${q} integer NOT NULL PRIMARY KEY, ${q}bytea${q} integer NULL, ${q}blob${q} blob NULL, ${q}blob2${q} blob NULL, ${q}clob${q} clob NULL, ${q}clob2${q} clob NULL, ${q}a_memo${q} integer NULL)");
+}
+
+# clean up our mess
+sub do_clean {
+
+  my $dbh = shift || return;
+
+  for my $q ('', '"') {
+    my @clean = (
+      "DROP TABLE ${q}bindtype_test${q}",
+    );
+    eval { $dbh -> do ($_) } for @clean;
+  }
+}
+
+END {
+  for ($dbh) {
+    next unless $_;
+    local $SIG{__WARN__} = sub {};
+    do_clean($_);
+    $_->disconnect;
+  }
+}