From: Michael G. Schwern <schwern@pobox.com>
Date: Mon, 24 Sep 2001 11:12:13 +0000 (-0400)
Subject: [REPATCH] Re: [PATCH lib/ExtUtils/Manifest.pm] Minor bug in comment logic in maniread... 
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=0e3309e278a56ec53ae7e503c90865065734f801;p=p5sagit%2Fp5-mst-13.2.git

[REPATCH] Re: [PATCH lib/ExtUtils/Manifest.pm] Minor bug in comment logic in maniread() on VMS
Message-ID: <20010924111213.G27885@blackrider>

p4raw-id: //depot/perl@12178
---

diff --git a/lib/ExtUtils/Manifest.pm b/lib/ExtUtils/Manifest.pm
index 4656ead..2d4d7e3 100644
--- a/lib/ExtUtils/Manifest.pm
+++ b/lib/ExtUtils/Manifest.pm
@@ -142,15 +142,15 @@ sub maniread {
     while (<M>){
 	chomp;
 	next if /^#/;
+
+        my($file, $comment) = /^(\S+)\s*(.*)/;
+        next unless $file;
+
 	if ($Is_MacOS) {
-	    my($item,$text) = /^(\S+)\s*(.*)/;
-	    $item = _macify($item);
-	    $item =~ s/\\([0-3][0-7][0-7])/sprintf("%c", oct($1))/ge;
-	    $read->{$item}=$text;
+	    $file = _macify($file);
+	    $file =~ s/\\([0-3][0-7][0-7])/sprintf("%c", oct($1))/ge;
 	}
 	elsif ($Is_VMS) {
-	    my($file)= /^(\S+)/;
-	    next unless $file;
 	    my($base,$dir) = File::Basename::fileparse($file);
 	    # Resolve illegal file specifications in the same way as tar
 	    $dir =~ tr/./_/;
@@ -158,9 +158,10 @@ sub maniread {
 	    if (@pieces > 2) { $base = shift(@pieces) . '.' . join('_',@pieces); }
 	    my $okfile = "$dir$base";
 	    warn "Debug: Illegal name $file changed to $okfile\n" if $Debug;
-	    $read->{"\L$okfile"}=$_;
+            $file = "\L$okfile";
 	}
-	else { /^(\S+)\s*(.*)/ and $read->{$1}=$2; }
+
+        $read->{$file} = $comment;
     }
     close M;
     $read;