From: Karen Etheridge Date: Thu, 12 Sep 2013 03:22:18 +0000 (-0700) Subject: oops, some of these variables aren't always initialized X-Git-Tag: 1.008013~1 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=0d174bf62741d7afd09c18923ec368f1cc3480ac;p=p5sagit%2Flocal-lib.git oops, some of these variables aren't always initialized --- diff --git a/Changes b/Changes index e8ec986..1add82c 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,7 @@ Revision history for local::lib + - fix undef value errors when not installing into a local::lib + 1.008012 2013-09-11 - now handling using -Mlocal::lib in a taintperl environment, by ensuring that all libs in PERL_LOCAL_LIB_ROOT are properly added to diff --git a/t/bad_variables.t b/t/bad_variables.t index 96e1992..c8bbb63 100644 --- a/t/bad_variables.t +++ b/t/bad_variables.t @@ -6,14 +6,14 @@ use local::lib (); # remember the original value of this, in case we are already running inside a # local::lib -my $orig_llr = $ENV{PERL_LOCAL_LIB_ROOT}; +my $orig_llr = $ENV{PERL_LOCAL_LIB_ROOT} || ''; my $dir1 = tempdir('test_local_lib-XXXXX', DIR => Cwd::abs_path('t'), CLEANUP => 1); my $dir2 = tempdir('test_local_lib-XXXXX', DIR => Cwd::abs_path('t'), CLEANUP => 1); my $dir3 = tempdir('test_local_lib-XXXXX', DIR => Cwd::abs_path('t'), CLEANUP => 1); ok(!(grep { $dir1 eq $_ } @INC), 'new dir is not already in @INC'); -ok(!(grep { $dir1 eq $_ } split /:/, $ENV{PERL5LIB}), 'new dir is not already in PERL5LIB'); +ok(!(grep { $dir1 eq $_ } split /:/, ($ENV{PERL5LIB}||'')), 'new dir is not already in PERL5LIB'); local::lib->import($dir1); local::lib->import($dir2); @@ -25,7 +25,7 @@ local::lib->import($dir1); is( $ENV{PERL_LOCAL_LIB_ROOT}, - join(':', $orig_llr, $dir2, $dir1), + join(':', (grep { $_ } $orig_llr, $dir2, $dir1)), 'dir1 should have been removed and added back in at the top', );