From: Peter Rabbitson Date: Fri, 5 Feb 2010 16:10:29 +0000 (+0000) Subject: Fix typo and borked test X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=0ae1217d4c8ec781f748789de447d07cc1395fbf;p=dbsrgits%2FDBIx-Class-Historic.git Fix typo and borked test --- diff --git a/lib/DBIx/Class/Storage/DBI.pm b/lib/DBIx/Class/Storage/DBI.pm index a597576..4333c4e 100644 --- a/lib/DBIx/Class/Storage/DBI.pm +++ b/lib/DBIx/Class/Storage/DBI.pm @@ -1833,7 +1833,7 @@ sub _select_args { && (ref $ident eq 'ARRAY' && @$ident > 1) # indicates a join && - scalar $self->_parser_order_by ($attrs->{order_by}) + scalar $self->_parse_order_by ($attrs->{order_by}) ) { # the RNO limit dialect above mangles the SQL such that the join gets lost # wrap a subquery here diff --git a/t/746mssql.t b/t/746mssql.t index a73bfea..ab1bc20 100644 --- a/t/746mssql.t +++ b/t/746mssql.t @@ -425,7 +425,7 @@ $schema->storage->_sql_maker->{name_sep} = '.'; having => \['1 = ?', [ test => 1 ] ], #test having propagation prefetch => 'owner', rows => 2, # 3 results total - order_by => { -desc => 'owner' }, + order_by => { -desc => 'me.owner' }, unsafe_subselect_ok => 1, }, );