From: Steve Hay Date: Tue, 5 Aug 2003 10:43:49 +0000 (+0100) Subject: Re: MakeMaker doesn't pasthru DEFINE command-line args to subdirs on Win32 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=0a7c666e19ecbf1103304b30268ae2c69de61220;p=p5sagit%2Fp5-mst-13.2.git Re: MakeMaker doesn't pasthru DEFINE command-line args to subdirs on Win32 Message-ID: <3F2F7C55.9020808@uk.radan.com> (The MM_Unix.pm part was dealt with in #20501.) p4raw-id: //depot/perl@20502 --- diff --git a/lib/ExtUtils/MM_Win32.pm b/lib/ExtUtils/MM_Win32.pm index d05c870..004694c 100644 --- a/lib/ExtUtils/MM_Win32.pm +++ b/lib/ExtUtils/MM_Win32.pm @@ -430,8 +430,10 @@ banner. sub pasthru { my($self) = shift; - return "PASTHRU = " . ($NMAKE ? "-nologo" : ""); -} + my $pasthru = $self->SUPER::pasthru(); + $pasthru =~ s/PASTHRU\s*=\s*/PASTHRU = -nologo / if $NMAKE; + return $pasthru; + } =item oneliner (o) diff --git a/lib/ExtUtils/t/MM_Win32.t b/lib/ExtUtils/t/MM_Win32.t index 315b915..69e4afb 100644 --- a/lib/ExtUtils/t/MM_Win32.t +++ b/lib/ExtUtils/t/MM_Win32.t @@ -254,8 +254,8 @@ unlink "${script_name}$script_ext" if -f "${script_name}$script_ext"; # pasthru() { - my $pastru = "PASTHRU = " . ($Config{make} =~ /^nmake/i ? "-nologo" : ""); - is( $MM->pasthru(), $pastru, 'pasthru()' ); + my $pasthru = ($Config{make} =~ /^nmake/i ? "/-nologo/" : ""); + like( $MM->pasthru(), $pasthru, 'pasthru()' ); } package FakeOut;