From: Peter Rabbitson Date: Thu, 10 Jan 2013 13:13:21 +0000 (+0100) Subject: Remove apparent pessimization introduced in 6a588797 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=07c8e705f14400762b204d10828b7f74ab7522b8;p=dbsrgits%2FDBIx-Class-Historic.git Remove apparent pessimization introduced in 6a588797 There is no conceivable reason why the attrs need to be recalculated on cursor reset. All tests seem to pass as well. Removing it as the calculation is quite expensive - if problems arise bisection will hopefully lead us here --- diff --git a/lib/DBIx/Class/ResultSet.pm b/lib/DBIx/Class/ResultSet.pm index 8ac4f2a..023eab3 100644 --- a/lib/DBIx/Class/ResultSet.pm +++ b/lib/DBIx/Class/ResultSet.pm @@ -1720,7 +1720,6 @@ another query. sub reset { my ($self) = @_; - delete $self->{_attrs} if exists $self->{_attrs}; $self->{all_cache_position} = 0; $self->cursor->reset; return $self;